[SPARK-43542][SS] Define a new error class and apply for the case where streaming query fails due to concurrent run of streaming query with same checkpoint #41205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericm-db
changed the title
MaxGekk
approved these changes
May 19, 2023
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
LGTM except of a minor comment.
Member
|
@ericm-db Could you allow GitHub actions in your fork and re-trigger GAs, please. |
ericm-db
changed the title
Contributor
Author
|
Thanks for the review! I've made the changes, and I think it's ready to merge now @MaxGekk @HeartSaVioR |
Member
|
+1, LGTM. Merging to master. |
MaxGekk
changed the title
Member
|
@ericm-db Congratulations with your first contribution to Apache Spark! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We are migrating to a new error framework in order to surface errors in a friendlier way to customers. This PR defines a new error class specifically for when there are concurrent updates to the log for the same batch ID
Why are the changes needed?
This gives more information to customers, and allows them to filter in a better way
Does this PR introduce any user-facing change?
How was this patch tested?
There is an existing test to check the error message upon this condition. Because we are only changing the error type, and not the error message, this test is sufficient.