[SPARK-43849][BUILD] Enable unused imports check for Scala 2.13 #41356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
May 29, 2023
| import org.apache.spark.connect.proto.{ExecutePlanResponse, SqlCommand, StreamingQueryCommand, StreamingQueryCommandResult, StreamingQueryInstanceId, WriteStreamOperationStart, WriteStreamOperationStartResult} | ||
| import org.apache.spark.connect.proto.ExecutePlanResponse.SqlCommandResult | ||
| import org.apache.spark.connect.proto.Parse.ParseFormat | ||
| import org.apache.spark.connect.proto.StreamingQueryCommand |
Contributor
Author
There was a problem hiding this comment.
Scala 2.13 checked them unused as they have already been imports in line 31
LuciferYang
commented
May 29, 2023
|
|
||
| package org.apache.spark.sql.catalyst.expressions | ||
|
|
||
| import scala.collection.{mutable, IterableFactory, IterableOps} |
Contributor
Author
There was a problem hiding this comment.
IterableFactory and IterableOps are unused imports
Contributor
Author
|
cc @dongjoon-hyun @HyukjinKwon FYI |
pom.xml
Outdated
| <arg>-Wconf:cat=unchecked&msg=outer reference:s</arg> | ||
| <arg>-Wconf:cat=unchecked&msg=eliminated by erasure:s</arg> | ||
| <arg>-Wconf:msg=^(?=.*?a value of type)(?=.*?cannot also be).+$:s</arg> | ||
|
|
Member
There was a problem hiding this comment.
nit. Redundant empty line.
Contributor
Author
There was a problem hiding this comment.
Thanks @dongjoon-hyun , e80f584 removed it
MaxGekk
approved these changes
May 29, 2023
Member
|
Merged to master. |
Contributor
Author
|
Thanks @dongjoon-hyun @MaxGekk |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? This pr aims to enable `unused imports` check for Scala 2.13. There is an exception here for `import scala.language.higherKinds`（Scala 2.13 does not need to import them , while Scala 2.12 must import them）, so this pr add two new suppression rules for it. ### Why are the changes needed? Enable `unused imports` check for Scala 2.13. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass Github Actions Closes apache#41356 from LuciferYang/SPARK-43849. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
LuciferYang
added a commit
that referenced
this pull request
Sep 27, 2023
…gherKinds` and delete the corresponding suppression rule ### What changes were proposed in this pull request? `scala.language.higherKinds` is deprecated and no longer needs to be imported explicitly in Scala 2.13, so this PR removes the imports for scala.language.higherKinds and the corresponding compiler suppression rules. ### Why are the changes needed? In SPARK-43849(#41356), I added compiler suppression rules to allow `unused imports` checks to work with both Scala 2.12 and Scala 2.13. As there is no longer a need to support Scala 2.12, we can now clean them up. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #43128 from LuciferYang/SPARK-43850. Authored-by: yangjie01 <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to enable
unused importscheck for Scala 2.13.There is an exception here for
import scala.language.higherKinds（Scala 2.13 does not need to import them , while Scala 2.12 must import them）, so this pr add two new suppression rules for it.Why are the changes needed?
Enable
unused importscheck for Scala 2.13.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass Github Actions