Skip to content

[SPARK-43376][SQL][FOLLOWUP] lazy construct subquery to improve reuse subquery #41454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ulysses-you wants to merge 5 commits into from
Closed

[SPARK-43376][SQL][FOLLOWUP] lazy construct subquery to improve reuse subquery #41454

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5231eb9
lazy construct subquery to improve reuse subquery
ulysses-you Jun 5, 2023
0ea7763
hold executed plan
ulysses-you Jun 5, 2023
eba1234
improve table cache
ulysses-you Jun 5, 2023
c231b92
address comment
ulysses-you Jun 6, 2023
ee7a476
address comment
ulysses-you Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address comment
  • Loading branch information
@ulysses-you
ulysses-you committed Jun 7, 2023
commit ee7a476c1ff48a54259662313fc4ed4f0f763060
14 changes: 9 additions & 5 deletions ...core/src/main/scala/org/apache/spark/sql/execution/adaptive/InsertAdaptiveSparkPlan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ package org.apache.spark.sql.execution.adaptive

import scala.collection.mutable

import org.apache.spark.sql.catalyst.expressions.SubqueryExpression
import org.apache.spark.sql.catalyst.expressions
import org.apache.spark.sql.catalyst.expressions.{DynamicPruningSubquery, ListQuery, SubqueryExpression}
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.catalyst.plans.physical.UnspecifiedDistribution
import org.apache.spark.sql.catalyst.rules.Rule
Expand Down Expand Up @@ -134,10 +135,13 @@ case class InsertAdaptiveSparkPlan(
return subqueryMap.toMap
}
plan.foreach(_.expressions.filter(_.containsPattern(PLAN_EXPRESSION)).foreach(_.foreach {
case subquery: SubqueryExpression if !subqueryMap.contains(subquery.exprId.id) =>
val executedPlan = compileSubquery(subquery.plan)
verifyAdaptivePlan(executedPlan, subquery.plan)
subqueryMap.put(subquery.exprId.id, executedPlan)
case e @ (_: expressions.ScalarSubquery | _: ListQuery | _: DynamicPruningSubquery) =>
val subquery = e.asInstanceOf[SubqueryExpression]
if (!subqueryMap.contains(subquery.exprId.id)) {
val executedPlan = compileSubquery(subquery.plan)
verifyAdaptivePlan(executedPlan, subquery.plan)
subqueryMap.put(subquery.exprId.id, executedPlan)
}
case _ =>
}))

Expand Down