Skip to content

[SPARK-43648][CONNECT][TESTS] Move interrupt all related test to a new test file to pass Maven test #41487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 9 commits into from
Closed

[SPARK-43648][CONNECT][TESTS] Move interrupt all related test to a new test file to pass Maven test #41487

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4963bd5
move to new file
LuciferYang Jun 6, 2023
b9e7e4a
add waring message to SparkSessionE2ESuite
LuciferYang Jun 7, 2023
4822924
re format
LuciferYang Jun 7, 2023
ca3e6b1
rename
LuciferYang Jun 7, 2023
3b885b2
Simplify comments
LuciferYang Jun 7, 2023
4648813
rename and comments
LuciferYang Jun 8, 2023
57e23f1
Update connector/connect/client/jvm/src/test/scala/org/apache/spark/s…
LuciferYang Jun 9, 2023
c71eac4
Merge branch 'apache:master' into SPARK-43648-2
LuciferYang Jun 9, 2023
5ec3f93
reformat
LuciferYang Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
re format
  • Loading branch information
@LuciferYang
LuciferYang committed Jun 7, 2023
commit 4822924706ce4b1425601135dd87923c1dbda78a
11 changes: 5 additions & 6 deletions connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/SparkSessionE2ESuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,11 @@ import org.apache.spark.sql.connect.client.util.RemoteSparkSession
import org.apache.spark.util.ThreadUtils

/**
* Warning: SPARK-43648 moves two test cases related to `interrupt all` from
* `ClientE2ETestSuite` to the current test class to avoid the maven test issue
* of missing `org.apache.spark.sql.connect.client.SparkResult` during udf
* deserialization in server side. So please don't import classes that only
* exist in `spark-connect-client-jvm.jar` into the this class, as it will
* trigger similar maven test failures again.
* Warning: SPARK-43648 moves two test cases related to `interrupt all` from `ClientE2ETestSuite`
* to the current test class to avoid the maven test issue of missing
* `org.apache.spark.sql.connect.client.SparkResult` during udf deserialization in server side. So
* please don't import classes that only exist in `spark-connect-client-jvm.jar` into the this
* class, as it will trigger similar maven test failures again.
*/
class SparkSessionE2ESuite extends RemoteSparkSession {
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jun 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the investigation and suggestion, @LuciferYang .

If this is supposed to be a clean room unlike ClientE2ETestSuite. Could you add some test class description officially here? For example, something like Do not import 'org.apache.spark.sql.connect.client.SparkResult? Or, Do not import any class from spark-connect-client-jvm.jar?

import some classes from spark-connect-client-jvm.jar, such as org.apache.spark.sql.connect.client.SparkResult

Without an explicit written warning, this test suite could be broken again when someone adds a new test case. It will be a head-ache of re-analysis.

Copy link
Contributor Author

@LuciferYang LuciferYang Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dongjoon-hyun ~

b9e7e4a add waring comments to SparkSessionE2ESuite.

At the same time, I am preparing a pr use to add Maven test of connect related modules on GitHub Action(#41253), as Maven testing often failures before. If this pr can be merged, we can start testing the client module first.

Copy link
Contributor

@vicennial vicennial Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: I wonder if we can also add something to the class name to make it more indicative that it's a "clean room" suite? Maybe something like SparkSessionCleanRoomE2ESuite or some variation.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry but let's not use CleanRoom keyword here, @vicennial . :)

Copy link
Contributor Author

@LuciferYang LuciferYang Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert


Expand Down