Revert "[SPARK-43840][INFRA] Switch scala-213 GitHub Action Job to scala-212"
#41506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`scala-212`" This reverts commit b93bd5e.
Contributor
Author
|
cc @dongjoon-hyun should we need revert this one? I found #41416 didn't do this thing |
dongjoon-hyun
approved these changes
Jun 8, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Oh, I missed this.
Sure. +1, LGTM.
dongjoon-hyun
approved these changes
Jun 8, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Oh, I missed this.
Sure. +1, LGTM.
Member
|
Is this a clean revert, @LuciferYang ? |
Member
|
I verified that this is a clean revert. Merged to master. |
Contributor
Author
|
Thanks @dongjoon-hyun Haha, I haven't had time to reply yet |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…`scala-212`" ### What changes were proposed in this pull request? This pr revert change of SPARK-43840, Spark 3.5.0 still use Scala 2.12 as default, so we need build check for Scala 2.13 for pull request. ### Why are the changes needed? Restore pipeline check for Scala 2.13. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#41506 from LuciferYang/r-43840. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr revert change of SPARK-43840, Spark 3.5.0 still use Scala 2.12 as default, so we need build check for Scala 2.13 for pull request.
Why are the changes needed?
Restore pipeline check for Scala 2.13.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions