Skip to content

[SPARK-44355][SQL] Move WithCTE into command queries #42036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 9 commits into from
Closed

[SPARK-44355][SQL] Move WithCTE into command queries #42036

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4eabbd8
Add WithCTEInChildren
MaxGekk Jul 16, 2023
4349764
with WithCTEInChildren
MaxGekk Jul 16, 2023
4f1cbee
Rename WithCTEInChildren to CTEInChildren
MaxGekk Jul 16, 2023
a6633e4
Remove isCommand
MaxGekk Jul 16, 2023
25230f2
Add withCTEDefs()
MaxGekk Jul 16, 2023
58bc261
Fix coding style issues
MaxGekk Jul 16, 2023
fedc9a6
fix
cloud-fan Jul 17, 2023
45672ac
address comments
cloud-fan Jul 22, 2023
8a36db1
Update sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLC…
cloud-fan Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLC… 
…onf.scala
  • Loading branch information
@cloud-fan
cloud-fan authored Jul 25, 2023
commit 8a36db13c932dbbb577fa53f8b1350e2ce2f309b
1 change: 1 addition & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3764,6 +3764,7 @@ object SQLConf {
.doc("If true, always inline the CTE relations for the queries in commands. This is the " +
"legacy behavior which may produce incorrect results because Spark may evaluate a CTE " +
"relation more than once, even if it's nondeterministic.")
.version("4.0.0")
.booleanConf
.createWithDefault(false)
Copy link
Contributor

@peter-toth peter-toth Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need version here?

Copy link
Contributor Author

@cloud-fan cloud-fan Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!


Expand Down