[SPARK-44509][PYTHON][CONNECT] Add job cancellation API set in Spark Connect Python client #42120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuszsompolski
approved these changes
Jul 24, 2023
Contributor
juliuszsompolski
left a comment
juliuszsompolski
left a comment
There was a problem hiding this comment.
LGTM, thank you!
zhengruifeng
approved these changes
Jul 25, 2023
Member
Author
|
Merged to master and branch-3.5. |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 25, 2023
…Connect Python client ### What changes were proposed in this pull request? This PR proposes the Python implementations for #42009. ### Why are the changes needed? For the feature parity, and better control of query cancelation in Spark Connect ### Does this PR introduce _any_ user-facing change? Yes. New Apis in Spark Connect Python client: ``` SparkSession.addTag SparkSession.removeTag SparkSession.getTags SparkSession.clearTags SparkSession.interruptTag SparkSession.interruptOperation ``` ### How was this patch tested? Unittests were added, and manually tested too. Closes #42120 from HyukjinKwon/SPARK-44509. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 5ee462d) Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
commented
Jul 25, 2023
| the $USER environment. Defining the user ID as part of the connection string | ||
| takes precedence. | ||
| """ | ||
| self.thread_local = threading.local() |
Member
Author
There was a problem hiding this comment.
BTW, there is difference here. Python's threadlocal isn't inheritable (and there's no such implementation in Python). So we should somehow workaround this ...
HyukjinKwon
added a commit
that referenced
this pull request
Jul 26, 2023
…cancellation API ### What changes were proposed in this pull request? This PR is a kind of a followup of #42120. This addresses my own comment at #42120 (comment) by adding the support of `InheritableThread` with Spark Connect. ### Why are the changes needed? In order to allow the thread local hierarchy supported in Scala side. ### Does this PR introduce _any_ user-facing change? The main PR is not released out yet so it doesn't have user-facing change. ### How was this patch tested? Unittests were added. Closes #42149 from HyukjinKwon/SPARK-44509-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Jul 31, 2023
### What changes were proposed in this pull request? This PR is a followup of #42120 that fixes the test class name from `ArrowParityTests` to `JobCancellationTests`. ### Why are the changes needed? The test class name doesn't make sense. It tests job cancellation. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unittests should be good enough. Closes #42229 from HyukjinKwon/minor-rename. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Jul 31, 2023
### What changes were proposed in this pull request? This PR is a followup of #42120 that fixes the test class name from `ArrowParityTests` to `JobCancellationTests`. ### Why are the changes needed? The test class name doesn't make sense. It tests job cancellation. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unittests should be good enough. Closes #42229 from HyukjinKwon/minor-rename. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit af6e177) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes the Python implementations for #42009.
Why are the changes needed?
For the feature parity, and better control of query cancelation in Spark Connect
Does this PR introduce any user-facing change?
Yes. New Apis in Spark Connect Python client:
How was this patch tested?
Unittests were added, and manually tested too.