[SPARK-41400][CONNECT] Remove Connect Client Catalyst Dependency #42184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
SQL
STRUCTURED STREAMING
BUILD
CORE
DSTREAM
AVRO
CONNECT
labels
Contributor
Author
|
This need #42164 to go in first. |
hvanhovell
commented
Jul 28, 2023
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Contributor
|
It is happening! |
amaliujia
approved these changes
Jul 28, 2023
Contributor
Author
|
Merging this. Single test failure, is a bit flaky. |
hvanhovell
added a commit
that referenced
this pull request
Jul 29, 2023
### What changes were proposed in this pull request? This PR decouples the Spark Connect Scala Client from Catalyst, it now used SQL API module instead. There were quite a few changes we still needed to make: - For testing we needed a bunch of utilities. I have moved these to common-utils. - I have moved bits and pieces of IntervalUtils to SparkIntervalUtils. - A lot of small fixes. ### Why are the changes needed? This reduces the client's dependency tree from ~300 MB of deps to ~30MB. This makes it easier to use the client when you are developing connect applications. On top of this the reduced dependency graph also means folks will be less affected by the clients' classpath. ### Does this PR introduce _any_ user-facing change? Yes. It changes the classpath exposed by the Spark Connect Scala Client. ### How was this patch tested? Existing tests. Closes #42184 from hvanhovell/SPARK-41400-v1. Authored-by: Herman van Hovell <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 85a4d1e) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR decouples the Spark Connect Scala Client from Catalyst, it now used SQL API module instead.
There were quite a few changes we still needed to make:
Why are the changes needed?
This reduces the client's dependency tree from ~300 MB of deps to ~30MB. This makes it easier to use the client when you are developing connect applications. On top of this the reduced dependency graph also means folks will be less affected by the clients' classpath.
Does this PR introduce any user-facing change?
Yes. It changes the classpath exposed by the Spark Connect Scala Client.
How was this patch tested?
Existing tests.