Skip to content

[SPARK-44776][CONNECT] Add ProducedRowCount to SparkListenerConnectOperationFinished #42454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gjxdxh wants to merge 4 commits into from
Closed

[SPARK-44776][CONNECT] Add ProducedRowCount to SparkListenerConnectOperationFinished #42454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
956f5c4
Add ProducedRowCount to SparkListenerConnectOperationFinished
Aug 11, 2023
2e3252d
Add row for command and add test
Aug 14, 2023
8dc4c91
update
Aug 15, 2023
6a7cee9
small update
Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
small update
  • Loading branch information
Lingkai Kong committed Aug 15, 2023
commit 6a7cee97fa282e78ff2810c62ad9989e4cc874dd
2 changes: 1 addition & 1 deletion ...ver/src/main/scala/org/apache/spark/sql/connect/execution/SparkConnectPlanExecution.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ private[execution] class SparkConnectPlanExecution(executeHolder: ExecuteHolder)
resultFunc = () => ())
// Collect errors and propagate them to the main thread.
.andThen {
case Success(_) =>
case Success(_) => // do nothing
case Failure(throwable) =>
signal.synchronized {
error = Some(throwable)
Expand Down
4 changes: 2 additions & 2 deletions ...ect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteEventsManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,11 +414,11 @@ case class SparkListenerConnectOperationFailed(
* 36 characters UUID assigned by Connect during a request.
* @param eventTime:
* The time in ms when the event was generated.
* @param extraTags:
* Additional metadata during the request.
* @param producedRowCount:
* Number of rows that are returned to the user. None is expected when the operation does not
* return any rows.
* @param extraTags:
* Additional metadata during the request.
*/
case class SparkListenerConnectOperationFinished(
jobTag: String,
Expand Down