-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-44435][SS][CONNECT] Tests for foreachBatch and Listener #42521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44435][SS][CONNECT] Tests for foreachBatch and Listener #42521
Conversation
python/pyspark/sql/tests/connect/streaming/test_parity_listener.py
Outdated
Show resolved
Hide resolved
| return {k[1:]: conv(v) for k, v in e.__dict__.items()} | ||
|
|
||
|
|
||
| def streaming_query_progress_as_dict(e: StreamingQueryProgress) -> Dict[str, Any]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simpler way might be pyspark.cloupickle.dumps(event), save that as a table, and load it back, and unpickle it via pyspark.cloudpickle.loads(binary) and compare them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks! Never thought of that
|
Merged to master and branch-3.5. |
### What changes were proposed in this pull request? Add several new test cases for streaming foreachBatch and streaming query listener events to test various scenarios. ### Why are the changes needed? More tests is better ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change Closes #42521 from WweiL/SPARK-44435-tests-foreachBatch-listener. Authored-by: Wei Liu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 2d44848) Signed-off-by: Hyukjin Kwon <[email protected]>
|
https://github.com/apache/spark/actions/runs/5962873768/job/16174987432 @WweiL Are there any related PRs that have not been merged into branch-3.5? The branch-3.5 daily test failed today. |
|
@LuciferYang Thanks for the ping! Let me checkout 3.5 and see |
|
Hi, all. I also saw the consecutive failures at three commits after this. Let me revert this from branch-3.5 first. |
|
This is reverted from branch-3.5 via 6c2da61 . |
### What changes were proposed in this pull request? Add several new test cases for streaming foreachBatch and streaming query listener events to test various scenarios. ### Why are the changes needed? More tests is better ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change Closes apache#42521 from WweiL/SPARK-44435-tests-foreachBatch-listener. Authored-by: Wei Liu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 2d44848) Signed-off-by: Hyukjin Kwon <[email protected]>
|
Created a separate PR to 3.5 |
What changes were proposed in this pull request?
Add several new test cases for streaming foreachBatch and streaming query listener events to test various scenarios.
Why are the changes needed?
More tests is better
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test only change