Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added TODO comment for simplifying the code
  • Loading branch information
bogao007 committed Aug 18, 2023
commit 5f6b8d07666563948dab9eb8ab996958363effe9
2 changes: 2 additions & 0 deletions python/pyspark/sql/connect/protobuf/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def from_protobuf(
elif descFilePath is not None:
binary_proto = _read_descriptor_set_file(descFilePath)

# TODO: simplify the code when _invoke_function() supports None as input.
if binary_proto is not None:
if options is None:
return _invoke_function(
Expand Down Expand Up @@ -85,6 +86,7 @@ def to_protobuf(
elif descFilePath is not None:
binary_proto = _read_descriptor_set_file(descFilePath)

# TODO: simplify the code when _invoke_function() supports None as input.
if binary_proto is not None:
if options is None:
return _invoke_function(
Expand Down