Skip to content

[SPARK-5482][PySpark] Allow individual test suites in python/run-tests #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
potix2 wants to merge 6 commits into from
Closed

[SPARK-5482][PySpark] Allow individual test suites in python/run-tests #4269

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f6ee2b
[SPARK-5482][PySpark] Allow individual test suites in python/run-tests
potix2 Jan 29, 2015
0421f60
Move conditional check into the test functions
potix2 Feb 23, 2015
5aa5aa5
Split run-tests into the main script and runner scripts for a particu…
potix2 Jun 17, 2015
36153f6
Remove unnecessary comments
potix2 Jun 19, 2015
6dec246
Add license headers.
potix2 Jun 19, 2015
e08f602
Remove redundant shift
potix2 Jun 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove redundant shift
  • Loading branch information
@potix2
potix2 committed Jun 19, 2015
commit e08f602c5f510132b313505fc4b7e704c901a8a8
3 changes: 1 addition & 2 deletions python/run-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ SUPPORT_PYTHON_VERSIONS="2.6 3.4 pypy"
TARGET_PYTHON_VERSION=
Copy link
Contributor

@JoshRosen JoshRosen Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing to me; are we just declaring a variable here?

if [ $# != 0 -a $1 == "-v" ]; then
Copy link
Contributor

@JoshRosen JoshRosen Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to double-quote $1?

Copy link
Contributor

@JoshRosen JoshRosen Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, this prints an error when I run it on my Mac:

[joshrosen python (2c6a7d4...)]$ ./run-tests
./run-tests: line 33: [: too many arguments

TARGET_PYTHON_VERSION=$2
shift
shift
shift 2
fi

if [ $# == 0 ]; then
Expand Down