SPARK-1483: Rename minSplits to minPartitions in public APIs #430

CodingCat · 2014-04-16T20:54:09Z

https://issues.apache.org/jira/browse/SPARK-1483

From the original JIRA: " The parameter name is part of the public API in Scala and Python, since you can pass named parameters to a method, so we should name it to this more descriptive term. Everywhere else we refer to "splits" as partitions." - @mateiz

AmplabJenkins · 2014-04-16T20:58:11Z

Merged build triggered.

AmplabJenkins · 2014-04-16T20:58:20Z

Merged build started.

AmplabJenkins · 2014-04-16T21:29:11Z

Merged build finished. All automated tests passed.

AmplabJenkins · 2014-04-16T21:29:11Z

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14186/

rxin · 2014-04-17T00:20:05Z

Maybe you want to deprecate defaultMinSplits, and create a defaultMinPartitions.

AmplabJenkins · 2014-04-17T03:48:11Z

Merged build triggered.

AmplabJenkins · 2014-04-17T03:48:18Z

Merged build started.

CodingCat · 2014-04-17T03:53:29Z

@rxin thanks for the comments, just addressed that and wait for Jenkins

AmplabJenkins · 2014-04-17T05:19:31Z

Merged build finished.

AmplabJenkins · 2014-04-17T05:19:31Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14199/

rxin · 2014-04-17T05:28:16Z

Jenkins, retest this please.

AmplabJenkins · 2014-04-17T05:33:11Z

Merged build triggered.

AmplabJenkins · 2014-04-17T05:33:18Z

Merged build started.

AmplabJenkins · 2014-04-17T07:04:25Z

Merged build finished.

AmplabJenkins · 2014-04-17T07:04:26Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14201/

rxin · 2014-04-17T07:14:01Z

Jenkins, retest this please.

AmplabJenkins · 2014-04-17T07:18:11Z

Merged build triggered.

AmplabJenkins · 2014-04-17T07:18:19Z

Merged build started.

AmplabJenkins · 2014-04-17T08:49:51Z

Merged build finished.

AmplabJenkins · 2014-04-17T08:49:51Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14204/

AmplabJenkins · 2014-04-17T10:58:11Z

Merged build triggered.

AmplabJenkins · 2014-04-17T10:58:20Z

Merged build started.

AmplabJenkins · 2014-04-17T12:29:45Z

Merged build finished.

AmplabJenkins · 2014-04-17T12:29:46Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14206/

CodingCat · 2014-04-17T12:47:23Z

it's weird...always timeout....because I modified core and hive-related file in the same PR?

AmplabJenkins · 2014-04-18T11:23:11Z

Merged build triggered.

AmplabJenkins · 2014-04-18T11:23:18Z

Merged build started.

AmplabJenkins · 2014-04-18T12:00:56Z

Merged build finished. All automated tests passed.

AmplabJenkins · 2014-04-18T12:00:56Z

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14233/

CodingCat · 2014-04-18T12:01:49Z

finally~thanks @rxin , any other comments?

rxin · 2014-04-18T17:01:37Z

Thanks. Merged.

@mateiz

https://issues.apache.org/jira/browse/SPARK-1483 From the original JIRA: " The parameter name is part of the public API in Scala and Python, since you can pass named parameters to a method, so we should name it to this more descriptive term. Everywhere else we refer to "splits" as partitions." - @mateiz Author: CodingCat <[email protected]> Closes #430 from CodingCat/SPARK-1483 and squashes the following commits: 4b60541 [CodingCat] deprecate defaultMinSplits ba2c663 [CodingCat] Rename minSplits to minPartitions in public APIs (cherry picked from commit e31c8ff) Signed-off-by: Reynold Xin <[email protected]>

@mateiz

https://issues.apache.org/jira/browse/SPARK-1483 From the original JIRA: " The parameter name is part of the public API in Scala and Python, since you can pass named parameters to a method, so we should name it to this more descriptive term. Everywhere else we refer to "splits" as partitions." - @mateiz Author: CodingCat <[email protected]> Closes apache#430 from CodingCat/SPARK-1483 and squashes the following commits: 4b60541 [CodingCat] deprecate defaultMinSplits ba2c663 [CodingCat] Rename minSplits to minPartitions in public APIs

Direct copy of revised design doc

* [SPARK-45382][BUILD] Upgrade Netty to 4.1.99.Final ### What changes were proposed in this pull request? This PR aims to Upgrade Netty to 4.1.99.Final. ### Why are the changes needed? Netty 4.1.99.Final is the first release where Netty community has Java 21 test coverage. - netty/netty#13627 It also fixes a bug which could lead to SIGSERV while running on JDK21+. Since the bug was introduced at `4.1.98.Final`, Apache Spark was not affected yet. - netty/netty#13640 Here is a full release note. - https://netty.io/news/2023/09/21/4-1-99-Final.html ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#43180 from dongjoon-hyun/SPARK-45382. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 0b68e41) * HADP-54076 Upgrade netty-codec-http2 to 4.1.110 --------- Co-authored-by: Dongjoon Hyun <[email protected]>

…" (apache#442) * Revert "[HDAP-54076][FOLLOW-UP] Fix could not find file ...libnetty_tcnative_linux_x86_64.so to copy (apache#437)" This reverts commit 720c28e. * Revert "[HADP-54076][SPARK-48420] Upgrade netty to 4.1.110 (apache#430)" This reverts commit 98f4ffe.

CodingCat added 2 commits April 18, 2014 07:25

Rename minSplits to minPartitions in public APIs

ba2c663

deprecate defaultMinSplits

4b60541

asfgit closed this in e31c8ff Apr 18, 2014

markhamstra pushed a commit to markhamstra/spark that referenced this pull request Nov 7, 2017

Updated with documentation (apache#430)

437eb89

Direct copy of revised design doc

arjunshroff pushed a commit to arjunshroff/spark that referenced this pull request Nov 24, 2020

MapR [SPARK-430] PID files should be under /opt/mapr/pid (apache#430)

1264326

SPARK-1483: Rename minSplits to minPartitions in public APIs #430

SPARK-1483: Rename minSplits to minPartitions in public APIs #430

Uh oh!

Conversation

CodingCat commented Apr 16, 2014

Uh oh!

AmplabJenkins commented Apr 16, 2014

Uh oh!

AmplabJenkins commented Apr 16, 2014

Uh oh!

AmplabJenkins commented Apr 16, 2014

Uh oh!

AmplabJenkins commented Apr 16, 2014

Uh oh!

rxin commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

CodingCat commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

rxin commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

rxin commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 17, 2014

Uh oh!

CodingCat commented Apr 17, 2014

Uh oh!

AmplabJenkins commented Apr 18, 2014

Uh oh!

AmplabJenkins commented Apr 18, 2014

Uh oh!

AmplabJenkins commented Apr 18, 2014

Uh oh!

AmplabJenkins commented Apr 18, 2014

Uh oh!

CodingCat commented Apr 18, 2014

Uh oh!

rxin commented Apr 18, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants