Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
1be285c
[SPARK-45022][SQL] Provide context for dataset API errors
peter-toth Sep 18, 2023
4a3bc50
Remove an unused import
MaxGekk Oct 12, 2023
541928c
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 16, 2023
13dc953
Add stubs
MaxGekk Oct 17, 2023
eccd67a
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 17, 2023
6a2a33f
Fix MiMa
MaxGekk Oct 18, 2023
a364f29
Update proto QueryContext
MaxGekk Oct 22, 2023
4dc6cf1
Remove TODO
MaxGekk Oct 22, 2023
c58985a
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 22, 2023
a4e2093
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 22, 2023
fe1381e
Re-gen base_pb2.py
MaxGekk Oct 22, 2023
98fbc97
Fix a compile error
MaxGekk Oct 23, 2023
bc842a7
Fix SparkThrowableSuite
MaxGekk Oct 23, 2023
8de761d
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 23, 2023
8e09da0
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 24, 2023
1c33a00
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 25, 2023
3bf3bb9
Replace code by fragment
MaxGekk Oct 25, 2023
2bfac72
Remove code from proto
MaxGekk Oct 25, 2023
744b8ae
Re-gen base_pb2
MaxGekk Oct 25, 2023
651ee45
code -> fragment
MaxGekk Oct 26, 2023
98a12b5
Resolve conflicts in MiMa
MaxGekk Oct 26, 2023
61b34e6
Fix SparkThrowableSuite
MaxGekk Oct 26, 2023
29110b5
Remove framesToDrop
MaxGekk Oct 26, 2023
810076d
Remove optional
MaxGekk Oct 27, 2023
4042fb4
Re-gen base_pb2
MaxGekk Oct 27, 2023
115eca3
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 30, 2023
50fb94f
Revert override
MaxGekk Oct 31, 2023
9a31a07
since 3.5.0 -> since 4.0.0
MaxGekk Oct 31, 2023
0aa7850
Rename the enum: Dataset -> DataFrame
MaxGekk Oct 31, 2023
fe7b4a8
Rename proto: DATASET -> DATAFRAME
MaxGekk Oct 31, 2023
9ee81a6
Merge remote-tracking branch 'origin/master' into context-for-dataset…
MaxGekk Oct 31, 2023
75e251d
Rename the class: DatasetQueryContext -> DataFrameQueryContext
MaxGekk Oct 31, 2023
605fa50
Update summary: Dataset -> DataFrame
MaxGekk Oct 31, 2023
3cf20d7
Re-gen base_pb2.py
MaxGekk Oct 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename the enum: Dataset -> DataFrame
  • Loading branch information
MaxGekk committed Oct 31, 2023
commit 0aa7850133397399dd43bccb0e18fb160853f431
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
@Evolving
public enum QueryContextType {
SQL,
Dataset
DataFrame
}
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ private[spark] object SparkThrowableHelper {
val stopIndex = c.stopIndex() + 1
if (stopIndex > 0) g.writeNumberField("stopIndex", stopIndex)
g.writeStringField("fragment", c.fragment())
case QueryContextType.Dataset =>
case QueryContextType.DataFrame =>
g.writeStringField("fragment", c.fragment())
g.writeStringField("callSite", c.callSite())
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ private[client] object GrpcExceptionConverter {
new QueryContext {
override def contextType(): QueryContextType = queryCtx.getContextType match {
case FetchErrorDetailsResponse.QueryContext.ContextType.DATASET =>
QueryContextType.Dataset
QueryContextType.DataFrame
case _ => QueryContextType.SQL
}
override def objectType(): String = queryCtx.getObjectType
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/scala/org/apache/spark/SparkFunSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ abstract class SparkFunSuite
"Invalid stopIndex of a query context. Actual:" + actual.toString)
assert(actual.fragment() === expected.fragment,
"Invalid fragment of a query context. Actual:" + actual.toString)
} else if (actual.contextType() == QueryContextType.Dataset) {
} else if (actual.contextType() == QueryContextType.DataFrame) {
assert(actual.fragment() === expected.fragment,
"Invalid code fragment of a query context. Actual:" + actual.toString)
assert(actual.callSite().matches(expected.callSitePattern),
Expand Down Expand Up @@ -487,7 +487,7 @@ abstract class SparkFunSuite
}

def apply(fragment: String, callSitePattern: String): ExpectedContext = {
new ExpectedContext(QueryContextType.Dataset, "", "", -1, -1, fragment, callSitePattern)
new ExpectedContext(QueryContextType.DataFrame, "", "", -1, -1, fragment, callSitePattern)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ class SparkThrowableSuite extends SparkFunSuite {
|}""".stripMargin)

class TestQueryContext2 extends QueryContext {
override val contextType = QueryContextType.Dataset
override val contextType = QueryContextType.DataFrame
override def objectName: String = throw new UnsupportedOperationException
override def objectType: String = throw new UnsupportedOperationException
override def startIndex: Int = throw new UnsupportedOperationException
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ case class SQLQueryContext(
case class DatasetQueryContext(
override val fragment: String,
override val callSite: String) extends QueryContext {
override val contextType = QueryContextType.Dataset
override val contextType = QueryContextType.DataFrame

override def objectType: String = throw new UnsupportedOperationException
override def objectName: String = throw new UnsupportedOperationException
Expand Down