Skip to content

Conversation

@heyihong
Copy link
Contributor

@heyihong heyihong commented Nov 8, 2023

What changes were proposed in this pull request?

  • Refactor Catalog Function APIs to use analyzer

Why are the changes needed?

  • Less duplicate logics. We should not directly invoke catalog APIs, but go through analyzer.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Nov 8, 2023
@heyihong
Copy link
Contributor Author

heyihong commented Nov 8, 2023

@cloud-fan @hvanhovell Please take a look

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-45842] Refactor Catalog Function APIs to use analyzer [SPARK-45842][SQL] Refactor Catalog Function APIs to use analyzer Nov 8, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants