Skip to content

[SPARK-46313][CORE] Log Spark HA recovery duration #44243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-46313][CORE] Log Spark HA recovery duration #44243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73b3a92
[SPARK-46313][CORE] Log Spark HA recovery duration
dongjoon-hyun Dec 7, 2023
09ca410
Address comments
dongjoon-hyun Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/main/scala/org/apache/spark/deploy/master/Master.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,8 +604,11 @@ private[deploy] class Master(
workers.count(_.state == WorkerState.UNKNOWN) == 0 &&
apps.count(_.state == ApplicationState.UNKNOWN) == 0

private var recoveryStartTimeNs = 0L

private def beginRecovery(storedApps: Seq[ApplicationInfo], storedDrivers: Seq[DriverInfo],
storedWorkers: Seq[WorkerInfo]): Unit = {
recoveryStartTimeNs = System.nanoTime()
for (app <- storedApps) {
logInfo("Trying to recover app: " + app.id)
try {
Expand Down Expand Up @@ -662,7 +665,8 @@ private[deploy] class Master(

state = RecoveryState.ALIVE
schedule()
logInfo("Recovery complete - resuming operations!")
val timeTakenNs = System.nanoTime() - recoveryStartTimeNs
logInfo(s"Recovery complete in ${timeTakenNs / 1000000000d}s - resuming operations!")
Copy link
Member

@yaooqinn yaooqinn Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.043445167s may be less readable for humans. How about rounding to milliseconds？

TimeUnit.NANOSECONDS.toMillis(timeTakenNs) ms or TimeUnit.NANOSECONDS.toMillis(timeTakenNs) / 1000.0 s

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

}

/**
Expand Down