Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 20, 2024

What changes were proposed in this pull request?

This PR aims to recover GitHub Action K8s IT to use the latest Minikube and to make it sure that Apache Spark K8s module are tested with all Minikubes without any issues.

BEFORE

  • Minikube: v1.30.1
  • K8s: v1.26.3

AFTER

  • Minikube: v1.32.0
  • K8s: v1.28.3

Why are the changes needed?

  • Previously, it was pinned due to the failure.
  • After this PR, we will track the latest Minikube and K8s version always.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft January 20, 2024 21:09
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review January 20, 2024 21:12
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 20, 2024

All tests passed.

cc @LuciferYang since this issue was filed by him

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@LuciferYang
Copy link
Contributor

Merged into master for Spark 4.0. Thanks @dongjoon-hyun ~

@dongjoon-hyun
Copy link
Member Author

Thank you, @LuciferYang !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-44495 branch January 21, 2024 00:58
dongjoon-hyun added a commit to dongjoon-hyun/spark that referenced this pull request Jan 21, 2024
This PR aims to recover GitHub Action K8s IT to use the latest Minikube and to make it sure that Apache Spark K8s module are tested with all Minikubes without any issues.

**BEFORE**
- Minikube: v1.30.1
- K8s: v1.26.3

**AFTER**
- Minikube: v1.32.0
- K8s: v1.28.3

- Previously, it was pinned due to the failure.
- After this PR, we will track the latest Minikube and K8s version always.

No.

Pass the CIs.

No.

Closes apache#44813 from dongjoon-hyun/SPARK-44495.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
dongjoon-hyun added a commit to dongjoon-hyun/spark that referenced this pull request Jan 21, 2024
This PR aims to recover GitHub Action K8s IT to use the latest Minikube and to make it sure that Apache Spark K8s module are tested with all Minikubes without any issues.

**BEFORE**
- Minikube: v1.30.1
- K8s: v1.26.3

**AFTER**
- Minikube: v1.32.0
- K8s: v1.28.3

- Previously, it was pinned due to the failure.
- After this PR, we will track the latest Minikube and K8s version always.

No.

Pass the CIs.

No.

Closes apache#44813 from dongjoon-hyun/SPARK-44495.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
dongjoon-hyun added a commit that referenced this pull request Jan 21, 2024
### What changes were proposed in this pull request?

This is a backport of #44813 .

This PR aims to recover GitHub Action K8s IT to use the latest Minikube and to make it sure that Apache Spark K8s module are tested with all Minikubes without any issues.

**BEFORE**
- Minikube: v1.30.1
- K8s: v1.26.3

**AFTER**
- Minikube: v1.32.0
- K8s: v1.28.3

### Why are the changes needed?

- Previously, it was pinned due to the failure.
- After this PR, we will track the latest Minikube and K8s version always.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #44819 from dongjoon-hyun/SPARK-44495-3.5.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit that referenced this pull request Jan 21, 2024
### What changes were proposed in this pull request?

This is a backport of #44813 .

This PR aims to recover GitHub Action K8s IT to use the latest Minikube and to make it sure that Apache Spark K8s module are tested with all Minikubes without any issues.

**BEFORE**
- Minikube: v1.30.1
- K8s: v1.26.3

**AFTER**
- Minikube: v1.32.0
- K8s: v1.28.3

### Why are the changes needed?

- Previously, it was pinned due to the failure.
- After this PR, we will track the latest Minikube and K8s version always.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #44820 from dongjoon-hyun/SPARK-44495-3.4.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Feb 7, 2024
This is a backport of apache#44813 .

This PR aims to recover GitHub Action K8s IT to use the latest Minikube and to make it sure that Apache Spark K8s module are tested with all Minikubes without any issues.

**BEFORE**
- Minikube: v1.30.1
- K8s: v1.26.3

**AFTER**
- Minikube: v1.32.0
- K8s: v1.28.3

- Previously, it was pinned due to the failure.
- After this PR, we will track the latest Minikube and K8s version always.

No.

Pass the CIs.

No.

Closes apache#44820 from dongjoon-hyun/SPARK-44495-3.4.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants