-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-46812][CONNECT][PYTHON] Make mapInPandas / mapInArrow support ResourceProfile #45232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
11930c9
a7ccd5e
95a75af
ca41951
30531ae
5e61437
ba5c25a
3899ada
0e0f91f
fb6d721
192e59e
1bdb284
7d1523f
7efa33b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,7 @@ import "google/protobuf/any.proto"; | |
| import "spark/connect/expressions.proto"; | ||
| import "spark/connect/types.proto"; | ||
| import "spark/connect/catalog.proto"; | ||
| import "spark/connect/common.proto"; | ||
|
|
||
| option java_multiple_files = true; | ||
| option java_package = "org.apache.spark.connect.proto"; | ||
|
|
@@ -893,6 +894,9 @@ message MapPartitions { | |
|
|
||
| // (Optional) Whether to use barrier mode execution or not. | ||
| optional bool is_barrier = 3; | ||
|
|
||
| // (Optional) ResourceProfile id used for the stage level scheduling. | ||
| optional int32 profile_id = 4; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need an extra RPC for that? Can't you attach the resource profile directly to this call?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @grundprinzip, The user still needs to know the exact ResourceProfile id, if we attach resource profile in the call, seems we can't get id in this call. |
||
| } | ||
|
|
||
| message GroupMap { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -569,6 +569,7 @@ def __hash__(self): | |
| "pyspark.resource.profile", | ||
| # unittests | ||
| "pyspark.resource.tests.test_resources", | ||
| "pyspark.resource.tests.test_connect_resources", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this test is for spark connect, I think we should move it to Module or maybe we can move the test cases in it to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This pull request already includes pyspark.sql.tests.connect.test_resources to test the general mapInPandas/mapInArrow functionality with ResourceProfile. On the other hand, |
||
| ], | ||
| ) | ||
|
|
||
|
|
@@ -1057,6 +1058,7 @@ def __hash__(self): | |
| "pyspark.sql.tests.connect.test_parity_pandas_udf_scalar", | ||
| "pyspark.sql.tests.connect.test_parity_pandas_udf_grouped_agg", | ||
| "pyspark.sql.tests.connect.test_parity_pandas_udf_window", | ||
| "pyspark.sql.tests.connect.test_resources", | ||
| ], | ||
| excluded_python_implementations=[ | ||
| "PyPy" # Skip these tests under PyPy since they require numpy, pandas, and pyarrow and | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these be uuids? Just to make sure that we have intentional difference and no off by one?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @grundprinzip,
I'm not quite following you about "by uuids".
So the basic implementation is