-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-47210][SQL] Addition of implicit casting without indeterminate support #45383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mihailomilosevic2001
wants to merge
80
commits into
apache:master
from
mihailomilosevic2001:SPARK-47210
Closed
Changes from 4 commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
b34544a
Implicit casting on collated expressions
mihailomilosevic2001 fdbfa44
Fix doc files
mihailomilosevic2001 ce9b027
Fix contains, startWith, endWith tests
mihailomilosevic2001 e537190
Fix imports
mihailomilosevic2001 b5a79c1
Fix docs and incorporate changes
mihailomilosevic2001 8321d0c
Fix tests in CollationSuite
mihailomilosevic2001 d178233
Add test and incorporate changes
mihailomilosevic2001 a4b9be7
Fix godlen files
mihailomilosevic2001 a6e7662
Incorporate StringType in findWiderCommonType
mihailomilosevic2001 e1d7ad5
Merge branch 'master' into SPARK-47210
mihailomilosevic2001 b3b1356
Fix ArrayType(StringType, _) casting in findWiderCommonType
mihailomilosevic2001 7773d13
Fix type mismatch error
mihailomilosevic2001 198a728
Merge branch 'apache:master' into SPARK-47210
mihailomilosevic2001 255b1ab
Incorporate changes and fix errors
mihailomilosevic2001 9ce417f
Merge branch 'master' into SPARK-47210
mihailomilosevic2001 50f3aa2
Fix errors
mihailomilosevic2001 ca0c84d
Rework casting
mihailomilosevic2001 880a1b1
Merge branch 'master' into SPARK-47210
mihailomilosevic2001 56d6c7c
Fix failing tests
mihailomilosevic2001 94e5259
Fix array cast errors
mihailomilosevic2001 ccb52ba
Fix additional errors
mihailomilosevic2001 9b1387b
Fix explicit collation search
mihailomilosevic2001 c9974e1
Fix scala style errors
mihailomilosevic2001 fca9a65
Add support for ImplicitCastInputTypes
mihailomilosevic2001 660d664
Fix accidental change in license header
mihailomilosevic2001 c8edd93
Fix null casting
mihailomilosevic2001 a91490b
Fix failing tests
mihailomilosevic2001 49a8d61
Move implicit casting when strings present
mihailomilosevic2001 4c4cd84
Fix unintentional changes
mihailomilosevic2001 66122a6
improve types.py
mihailomilosevic2001 50f46e4
Refactor code
mihailomilosevic2001 cc86a87
Merge branch 'master' into SPARK-47210
mihailomilosevic2001 c01e80c
Fix imports and failing tests
mihailomilosevic2001 cc797a2
Disable casting of StructTypes
mihailomilosevic2001 5d001ee
Fix imports
mihailomilosevic2001 c68fc7d
Fix concat tests
mihailomilosevic2001 1c926ab
Fix unnecessary repetition
mihailomilosevic2001 dec39bf
Remove Elt test
mihailomilosevic2001 e808446
Remove tests for Repeat
mihailomilosevic2001 ca1a23a
Merge branch 'master' into SPARK-47210
mihailomilosevic2001 116931c
Merge branch 'apache:master' into SPARK-47210
mihailomilosevic2001 af487a2
Fix failing tests
mihailomilosevic2001 4ba7055
Fix nullability for StringType->StringType
mihailomilosevic2001 e490e42
Improve comments and switch tests from E2E to unit tests
mihailomilosevic2001 00e88e7
Add new tests and remove compatibility test
mihailomilosevic2001 85b4d16
Fix conflict resolution mistake
mihailomilosevic2001 30f7225
Merge branch 'apache:master' into SPARK-47210
mihailomilosevic2001 e89a354
Add indeterminate collation tests
mihailomilosevic2001 788dc06
Fix test
mihailomilosevic2001 75c0140
Block Alias on Indeterminate
mihailomilosevic2001 2918413
Merge remote-tracking branch 'upstream/master' into SPARK-47210
mihailomilosevic2001 f6ed55a
Remove introduction of indeterminate collation
mihailomilosevic2001 98960c0
Fix import problem
mihailomilosevic2001 de623c8
Fix failing tests
mihailomilosevic2001 a92b4e1
Fix pyspark error
mihailomilosevic2001 f7f3011
Merge branch 'apache:master' into SPARK-47210
mihailomilosevic2001 f67808e
Fix errors
mihailomilosevic2001 815ce42
Fix schema error
mihailomilosevic2001 7fca38a
Merge remote-tracking branch 'upstream/master' into SPARK-47210
mihailomilosevic2001 b19b0eb
Fix collated tests
mihailomilosevic2001 a111f03
Add isExplicit flag
mihailomilosevic2001 55bdd9b
Fix import error
mihailomilosevic2001 a7228be
Fix imports in TypeCoercion
mihailomilosevic2001 27a72c6
Merge remote-tracking branch 'upstream/master' into SPARK-47210
mihailomilosevic2001 18ada04
Add support for explicit propagation in arrays
mihailomilosevic2001 38670af
Fix tests to follow recent changes
mihailomilosevic2001 01d891e
Incorporate changes
mihailomilosevic2001 c5daf86
Fix error
mihailomilosevic2001 9ac5678
Change var to val in StringType
mihailomilosevic2001 0f1757d
Fix import style
mihailomilosevic2001 506c8c0
Revert explicit flag addition
mihailomilosevic2001 f743cf8
Narrow down expressions casting
mihailomilosevic2001 4f8fe1d
Incorporate minor changes
mihailomilosevic2001 52bf4dc
Incorporate changes
mihailomilosevic2001 7cbeafe
Special case expressions
mihailomilosevic2001 3e92e92
Return new line
mihailomilosevic2001 b23e106
Remove indentation cosmetic
mihailomilosevic2001 880ebed
Add more cosmetic changes
mihailomilosevic2001 f96ecd9
Incorporate changes
mihailomilosevic2001 e1e0cf4
Merge branch 'apache:master' into SPARK-47210
mihailomilosevic2001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
docs/sql-error-conditions-collation-mismatch-error-class.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| --- | ||
| layout: global | ||
| title: COLLATION_MISMATCH error class | ||
| displayTitle: COLLATION_MISMATCH error class | ||
| license: | | ||
| Licensed to the Apache Software Foundation (ASF) under one or more | ||
| contributor license agreements. See the NOTICE file distributed with | ||
| this work for additional information regarding copyright ownership. | ||
| The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| (the "License"); you may not use this file except in compliance with | ||
| the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --- | ||
|
|
||
| <!-- | ||
| DO NOT EDIT THIS FILE. | ||
| It was generated automatically by `org.apache.spark.SparkThrowableSuite`. | ||
| --> | ||
|
|
||
| [SQLSTATE: 42P21](sql-error-conditions-sqlstates.html#class-42-syntax-error-or-access-rule-violation) | ||
|
|
||
| Could not determine which collation to use for string comparison. | ||
|
|
||
| This error class has the following derived error classes: | ||
|
|
||
| ## EXPLICIT | ||
|
|
||
| Error occurred due to the mismatch between explicit collations "`<left>`" and "`<right>`" | ||
|
|
||
| ## IMPLICIT | ||
|
|
||
| Error occurred due to the mismatch between multiple implicit collations. Use COLLATE function to set the collation explicitly. | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.