[SPARK-47380][CONNECT] Ensure on the server side that the SparkSession is the same #45499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is the same In this PR we change the client behaviour to send the previously observed server session id so that the server can validate that the client used to talk with this specific session. Previously this was only validated on the client side which made the server actually execute the request for the wrong session before throwing on the client side (once the response from the server was obtained). Testing: Existing unit tests, add new unit test, e2e test added, manual testing
nemanja-boric-databricks
force-pushed
the
workspace
branch
from
fb07c9c to
f7a0cfb
Compare
Contributor
Author
|
Failed suite is: But it passed for the previous commits in this PR, it seems unrelated. |
hvanhovell
reviewed
Mar 18, 2024
| .setClientType(userAgent) | ||
| .build() | ||
| bstub.releaseSession(request) | ||
| bstub.releaseSession(request.build()) |
Contributor
There was a problem hiding this comment.
These two lines are equivalent right?
Contributor
Author
There was a problem hiding this comment.
Yes, this is just to make it uniform to everything else.
Contributor
|
Merging test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR we change the client behaviour to send the previously observed server session id so that the server can validate that the client used to talk with this specific session. Previously this was only validated on the client side which made the server actually execute the request for the wrong session before throwing on the client side (once the response from the server was obtained).
Why are the changes needed?
The server can execute the client command on the wrong spark session before client figuring out it's the different session.
Does this PR introduce any user-facing change?
The error message now pops up differently (it used to be a slightly different message when validated on the client).
How was this patch tested?
Existing unit tests, add new unit test, e2e test added, manual testing
Was this patch authored or co-authored using generative AI tooling?
No