[SPARK-47689][SQL] Do not wrap query execution error during data writing #45797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
changed the title
Contributor
Author
HyukjinKwon
approved these changes
Apr 2, 2024
Contributor
Author
|
thanks for the review, merging to master! |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @cloud-fan and @HyukjinKwon .
cloud-fan
added a commit
that referenced
this pull request
Apr 4, 2024
…ILED error ### What changes were proposed in this pull request? This is a follow-up of #45797 . Instead of detecting query execution errors and not wrapping them, it's better to do the error wrapping only in the data writer, which has more context. We can provide the specific file path when the error happened, instead of the destination directory name. ### Why are the changes needed? better error message ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? updated tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #45844 from cloud-fan/write-error. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
zhouyuan
pushed a commit
to apache/incubator-gluten
that referenced
this pull request
Nov 27, 2025
After this PR apache/spark#45797, exception will not be wrapped. This patch fixed the behavior in Spark shim layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's quite confusing to report
TASK_WRITE_FAILEDerror when the error was caused by input query execution. This PR updates the error wrapping code to not wrap withTASK_WRITE_FAILEDif the error was from input query execution.Why are the changes needed?
better error reporting
Does this PR introduce any user-facing change?
yes, now people won't see
TASK_WRITE_FAILEDerror if the error was from input query.How was this patch tested?
updated tests
Was this patch authored or co-authored using generative AI tooling?
no