Skip to content

[SPARK-47688][CORE] Support three methods of the log concatenation in the structured logging framework #45813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panbingkun wants to merge 7 commits into from
Closed

[SPARK-47688][CORE] Support three methods of the log concatenation in the structured logging framework #45813

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
89afe18
[SPARK-47688][CORE] Support concatenation `normal variables` and `MDC`
panbingkun Apr 2, 2024
834fdfc
fix it
panbingkun Apr 2, 2024
64bcd8e
add new syntax
panbingkun Apr 2, 2024
1ead521
fix
panbingkun Apr 2, 2024
3cf47fa
fix
panbingkun Apr 2, 2024
bce5f10
Merge branch 'master' into SPARK-47688
panbingkun Apr 2, 2024
338fbcd
fix
panbingkun Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@panbingkun
panbingkun committed Apr 2, 2024
commit 3cf47faff118f61ebe54a380f483d5a5102387fd
4 changes: 2 additions & 2 deletions common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ trait LoggingSuiteBase
log"Hello $basicMsg, Lost executor ${MDC(EXECUTOR_ID, "1")}."

def concatMDCAndString: LogEntry =
(log"Lost executor ${MDC(EXECUTOR_ID, "1")}." ++ s" Hello $basicMsg.")
log"Lost executor ${MDC(EXECUTOR_ID, "1")}." ++ s" Hello $basicMsg."

def concatStringAndMDC: LogEntry =
(s"Hello $basicMsg, " ++ log"Lost executor ${MDC(EXECUTOR_ID, "1")}.")
s"Hello $basicMsg, " ++ log"Lost executor ${MDC(EXECUTOR_ID, "1")}."

def expectedPatternForMsgWithMDC(level: Level): String

Expand Down