Skip to content

[SPARK-47700][SQL] Fix formatting of error messages with treeNode #45825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jchen5 wants to merge 2 commits into from
Closed

[SPARK-47700][SQL] Fix formatting of error messages with treeNode #45825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a22ea84
fix formatting of treeNode in errors
jchen5 Mar 27, 2024
9e588f2
update newlines
jchen5 Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions common/utils/src/main/resources/error/error-classes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4497,7 +4497,8 @@
"subClass" : {
"ACCESSING_OUTER_QUERY_COLUMN_IS_NOT_ALLOWED" : {
"message" : [
"Accessing outer query column is not allowed in this location<treeNode>."
"Accessing outer query column is not allowed in this location:",
"<treeNode>"
]
},
"AGGREGATE_FUNCTION_MIXED_OUTER_LOCAL_REFERENCES" : {
Expand All @@ -4507,7 +4508,8 @@
},
"CORRELATED_COLUMN_IS_NOT_ALLOWED_IN_PREDICATE" : {
"message" : [
"Correlated column is not allowed in predicate: <treeNode>."
"Correlated column is not allowed in predicate:",
"<treeNode>"
]
},
"CORRELATED_COLUMN_NOT_FOUND" : {
Expand Down Expand Up @@ -4542,7 +4544,8 @@
},
"NON_DETERMINISTIC_LATERAL_SUBQUERIES" : {
"message" : [
"Non-deterministic lateral subqueries are not supported when joining with outer relations that produce more than one row<treeNode>."
"Non-deterministic lateral subqueries are not supported when joining with outer relations that produce more than one row:",
"<treeNode>"
]
},
"UNSUPPORTED_CORRELATED_REFERENCE_DATA_TYPE" : {
Expand All @@ -4552,17 +4555,20 @@
},
"UNSUPPORTED_CORRELATED_SCALAR_SUBQUERY" : {
"message" : [
"Correlated scalar subqueries can only be used in filters, aggregations, projections, and UPDATE/MERGE/DELETE commands<treeNode>."
"Correlated scalar subqueries can only be used in filters, aggregations, projections, and UPDATE/MERGE/DELETE commands:",
"<treeNode>"
]
},
"UNSUPPORTED_IN_EXISTS_SUBQUERY" : {
"message" : [
"IN/EXISTS predicate subqueries can only be used in filters, joins, aggregations, window functions, projections, and UPDATE/MERGE/DELETE commands<treeNode>."
"IN/EXISTS predicate subqueries can only be used in filters, joins, aggregations, window functions, projections, and UPDATE/MERGE/DELETE commands:",
"<treeNode>"
]
},
"UNSUPPORTED_TABLE_ARGUMENT" : {
"message" : [
"Table arguments are used in a function where they are not supported<treeNode>."
"Table arguments are used in a function where they are not supported:",
"<treeNode>"
]
}
},
Expand Down
2 changes: 2 additions & 0 deletions core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ class SparkThrowableSuite extends SparkFunSuite {
}
messageSeq.foreach { message =>
message.foreach { msg =>
// Error messages in the JSON file should not contain newline characters:
// newlines are delineated as different elements in the array.
assert(!msg.contains("\n"))
assert(msg.trim == msg)
}
Expand Down
18 changes: 12 additions & 6 deletions docs/sql-error-conditions-unsupported-subquery-expression-category-error-class.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,17 @@ This error class has the following derived error classes:

## ACCESSING_OUTER_QUERY_COLUMN_IS_NOT_ALLOWED

Accessing outer query column is not allowed in this location`<treeNode>`.
Accessing outer query column is not allowed in this location:
`<treeNode>`

## AGGREGATE_FUNCTION_MIXED_OUTER_LOCAL_REFERENCES

Found an aggregate function in a correlated predicate that has both outer and local references, which is not supported: `<function>`.

## CORRELATED_COLUMN_IS_NOT_ALLOWED_IN_PREDICATE

Correlated column is not allowed in predicate: `<treeNode>`.
Correlated column is not allowed in predicate:
`<treeNode>`

## CORRELATED_COLUMN_NOT_FOUND

Expand Down Expand Up @@ -68,22 +70,26 @@ A GROUP BY clause in a scalar correlated subquery cannot contain non-correlated

## NON_DETERMINISTIC_LATERAL_SUBQUERIES

Non-deterministic lateral subqueries are not supported when joining with outer relations that produce more than one row`<treeNode>`.
Non-deterministic lateral subqueries are not supported when joining with outer relations that produce more than one row:
`<treeNode>`

## UNSUPPORTED_CORRELATED_REFERENCE_DATA_TYPE

Correlated column reference '`<expr>`' cannot be `<dataType>` type.

## UNSUPPORTED_CORRELATED_SCALAR_SUBQUERY

Correlated scalar subqueries can only be used in filters, aggregations, projections, and UPDATE/MERGE/DELETE commands`<treeNode>`.
Correlated scalar subqueries can only be used in filters, aggregations, projections, and UPDATE/MERGE/DELETE commands:
`<treeNode>`

## UNSUPPORTED_IN_EXISTS_SUBQUERY

IN/EXISTS predicate subqueries can only be used in filters, joins, aggregations, window functions, projections, and UPDATE/MERGE/DELETE commands`<treeNode>`.
IN/EXISTS predicate subqueries can only be used in filters, joins, aggregations, window functions, projections, and UPDATE/MERGE/DELETE commands:
`<treeNode>`

## UNSUPPORTED_TABLE_ARGUMENT

Table arguments are used in a function where they are not supported`<treeNode>`.
Table arguments are used in a function where they are not supported:
`<treeNode>`