[SPARK-47714][SQL] Set spark.sql.legacy.timeParserPolicy to CORRECTED by default #45853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
migration guide? |
yaooqinn
reviewed
Apr 3, 2024
| .transform(_.toUpperCase(Locale.ROOT)) | ||
| .checkValues(LegacyBehaviorPolicy.values.map(_.toString)) | ||
| .createWithDefault(LegacyBehaviorPolicy.EXCEPTION.toString) | ||
| .createWithDefault(LegacyBehaviorPolicy.CORRECTED.toString) |
Member
There was a problem hiding this comment.
Please also refresh the config doc field
Member
There was a problem hiding this comment.
Yes let's update the doc "The default value is EXCEPTION..."
yaooqinn
approved these changes
Apr 3, 2024
dongjoon-hyun
approved these changes
Apr 3, 2024
Member
There was a problem hiding this comment.
+1, LGTM with the same above doc comments (migration guide and config doc field).
Also, please fix all test case failures like the following.
[info] TimestampFormatterSuite:
[info] - explicitly forbidden datetime patterns (13 milliseconds)
[info] - SPARK-31939: Fix Parsing day of year when year field pattern is missing *** FAILED *** (4 milliseconds)
Contributor
Author
|
closing in favor of #45859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This config was added in 3.0 and it's time to use the CORRECTED behavior by default. This is not a big deal as the CORRECTED behavior is also throwing an error, but the error message is improved to show the actual problem.
Why are the changes needed?
better error message
Does this PR introduce any user-facing change?
error message becomes different
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no