-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-5794] [SQL] fix add jar #4586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
95a40da
support env argus in add jar, and set add jar ret to 0
adrian-wang 1898309
fix classnotfound
adrian-wang 0810e71
remove variable substitution
adrian-wang 9957d87
use sessionstate classloader in makeRDDforTable
adrian-wang 32c4fb8
fix style and add a test
adrian-wang 6c707e8
restrict hive version for test
adrian-wang efdd602
move jar to another place
adrian-wang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use sessionstate classloader in makeRDDforTable
- Loading branch information
commit 9957d870063c70e12c850c07192ada2eeb11a9e7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
sql/hive/src/test/resources/golden/mapjoin_addjar-0-24ca942f094b14b92086305cc125e833
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
sql/hive/src/test/resources/golden/mapjoin_addjar-1-af94522fc83baa9eb24b1b7b4f3cd4cf
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
sql/hive/src/test/resources/golden/mapjoin_addjar-2-6495971470ebbe1dd19ca4b685a80b63
This file was deleted.
Oops, something went wrong.
Empty file removed
0
sql/hive/src/test/resources/golden/mapjoin_addjar-3-713aab39b84aa056e9c44d7a9bf93289
Empty file.
Empty file removed
0
sql/hive/src/test/resources/golden/mapjoin_addjar-4-858b164eda56e098874284a78d8e105c
Empty file.
1 change: 0 additions & 1 deletion
1
sql/hive/src/test/resources/golden/mapjoin_addjar-5-404e814127ca6d7fd2ec53557f9711e1
This file was deleted.
Oops, something went wrong.
Empty file removed
0
sql/hive/src/test/resources/golden/mapjoin_addjar-6-ca16024e6f5399b1d035f5b9fd665163
Empty file.
1 change: 0 additions & 1 deletion
1
sql/hive/src/test/resources/golden/mapjoin_addjar-7-b1e2ade89ae898650f0be4f796d8947b
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrian-wang Why we need a Row with a value of 0 at here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hive would return a
0for add jar command.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I thought it may be better to comment at the original pr).
OK, I see. In future, let's make sure we also update the
outputif the result of a command is not an empty Seq (#5350 will change the schema forAddJar).