Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Apr 3, 2024

What changes were proposed in this pull request?

Add -Dio.netty.tryReflectionSetAccessible=true for spark-connect-scala-client

Why are the changes needed?

The previous change missed spark-connect-scala-client, may be due to bad IDEA index.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

Was this patch authored or co-authored using generative AI tooling?

No

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-trigger the failed test pipeline, @pan3793 ?

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@pan3793
Copy link
Member Author

pan3793 commented Apr 4, 2024

@dongjoon-hyun @HyukjinKwon thanks, CI is green now

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @pan3793 .
Merged to master.

turboFei pushed a commit to turboFei/spark that referenced this pull request Nov 6, 2025
…sible=true for spark-connect-scala-client

### What changes were proposed in this pull request?

Add `-Dio.netty.tryReflectionSetAccessible=true` for `spark-connect-scala-client`

### Why are the changes needed?

The previous change missed spark-connect-scala-client, may be due to bad IDEA index.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#45860 from pan3793/SPARK-47610-followup.

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>

(cherry picked from commit e3405c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants