Skip to content

[SPARK-47705][INFRA][FOLLOWUP] Sort LogKey alphabetically and build a test to ensure it #45864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panbingkun wants to merge 2 commits into from
Closed

[SPARK-47705][INFRA][FOLLOWUP] Sort LogKey alphabetically and build a test to ensure it #45864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27923d7
[SPARK-47705][INFRA][FOLLOWUP] Sort LogKey alphabetically and build a…
panbingkun Apr 3, 2024
2ce3117
fix code style
panbingkun Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ object LogKey extends Enumeration {
val MAX_EXECUTOR_FAILURES = Value
val MAX_SIZE = Value
val MIN_SIZE = Value
val REMOTE_ADDRESS = Value
val POD_ID = Value
val REMOTE_ADDRESS = Value

type LogKey = Value
}
3 changes: 2 additions & 1 deletion common/utils/src/test/scala/org/apache/spark/util/LogKeySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class LogKeySuite

test("LogKey enumeration fields must be sorted alphabetically") {
val keys = LogKey.values.toSeq
assert(keys === keys.sorted, "LogKey enumeration fields must be sorted alphabetically")
assert(keys === keys.sortBy(_.toString),
"LogKey enumeration fields must be sorted alphabetically")
}
}