Skip to content

[SPARK-47734][PYTHON][TESTS] Fix flaky DataFrame.writeStream doctest by stopping streaming query #45885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 2 commits into from
Closed

[SPARK-47734][PYTHON][TESTS] Fix flaky DataFrame.writeStream doctest by stopping streaming query #45885

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7580f
fix test
JoshRosen Apr 4, 2024
9602085
amend
JoshRosen Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix test
  • Loading branch information
@JoshRosen
JoshRosen committed Apr 4, 2024
commit ce7580f3d838f6a5f5fd6927719855e53b3cd41c
6 changes: 5 additions & 1 deletion python/pyspark/sql/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,15 +589,19 @@ def writeStream(self) -> DataStreamWriter:

Examples
--------
>>> import time
>>> import tempfile
>>> df = spark.readStream.format("rate").load()
>>> type(df.writeStream)
<class '...streaming.readwriter.DataStreamWriter'>

>>> with tempfile.TemporaryDirectory(prefix="writeStream") as d:
... # Create a table with Rate source.
... df.writeStream.toTable(
... query = df.writeStream.toTable(
... "my_table", checkpointLocation=d)
... print(type(query))
... time.sleep(3)
Copy link
Contributor Author

@JoshRosen JoshRosen Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied this from

spark/python/pyspark/sql/dataframe.py

Lines 1246 to 1253 in 9602085

>>> query = (df
... .withWatermark("timestamp", "10 minutes")
... .groupBy(
... window(df.timestamp, "10 minutes", "5 minutes"),
... df.value)
... ).count().writeStream.outputMode("complete").format("console").start()
>>> time.sleep(3)
>>> query.stop()

... query.stop()
<...streaming.query.StreamingQuery object at 0x...>
"""
return DataStreamWriter(self)
Expand Down