Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #45868 that proposes to make testing script to inherits SPARK_CONNECT_TESTING_REMOTE environment variable.

Why are the changes needed?

So the testing script can set SPARK_CONNECT_TESTING_REMOTE, and makes the env effective.

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

Manually tested at #45870

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the PYTHON label Apr 5, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants