Skip to content

[SPARK-48047][SQL] Reduce memory pressure of empty TreeNode tags #46285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n-young-db wants to merge 6 commits into from
Closed

[SPARK-48047][SQL] Reduce memory pressure of empty TreeNode tags #46285

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad49a31
Reduce memory pressure of empty TreeNode tags
n-young-db Apr 29, 2024
70dfc02
comments
n-young-db Apr 29, 2024
dbf703d
comment
n-young-db Apr 29, 2024
866c028
comment
n-young-db Apr 29, 2024
6303972
comment
n-young-db Apr 29, 2024
09c93e4
isEmpty
n-young-db Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment
  • Loading branch information
@n-young-db
n-young-db committed Apr 29, 2024
commit dbf703d2f3fed2c84df8b70b7645db68e1acd4ff
2 changes: 2 additions & 0 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
/**
* A mutable map for holding auxiliary information of this tree node. It will be carried over
* when this node is copied via `makeCopy`, or transformed via `transformUp`/`transformDown`.
* We lazily evaluate the `tags` since the default size of a `mutable.Map` is nonzero. This
* will reduce unnecessary memory pressure.
*/
private[this] var _tags: mutable.Map[TreeNodeTag[_], Any] = null
private def tags: mutable.Map[TreeNodeTag[_], Any] = {
Expand Down