-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-47579][CORE][PART4] Migrate logInfo with variables to structured logging framework #46724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3631a04
Migrate to structured logging
zeotuan 85a560f
Migrate to structured logging
zeotuan 1337771
Merge branch 'master' of https://github.com/zeotuan/spark into coreInfo3
zeotuan 06e7f7e
Fix formatting
zeotuan ed4624e
Fix formatting
zeotuan 9ad231b
Order LogKeys
zeotuan d214b31
Merge master
zeotuan cb0b980
Migrate to structure logging
zeotuan 6db64bd
Resolve review
zeotuan 7865b72
Fix key ordering
zeotuan e970298
fix ambiguous import. Remove unused key
zeotuan a408ebc
Reorder import
zeotuan 32d0cd2
Reorder import
zeotuan f1ed4f2
Update common/utils/src/main/scala/org/apache/spark/internal/LogKey.s…
gengliangwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,9 +31,13 @@ trait LogKey { | |
| */ | ||
| object LogKeys { | ||
| case object ACCUMULATOR_ID extends LogKey | ||
| case object ACL_ENABLED extends LogKey | ||
| case object ACTUAL_BROADCAST_OUTPUT_STATUS_SIZE extends LogKey | ||
| case object ACTUAL_NUM_FILES extends LogKey | ||
| case object ACTUAL_PARTITION_COLUMN extends LogKey | ||
| case object ADDED_JARS extends LogKey | ||
| case object ADMIN_ACLS extends LogKey | ||
| case object ADMIN_ACL_GROUPS extends LogKey | ||
| case object AGGREGATE_FUNCTIONS extends LogKey | ||
| case object ALPHA extends LogKey | ||
| case object ANALYSIS_ERROR extends LogKey | ||
|
|
@@ -44,7 +48,9 @@ object LogKeys { | |
| case object APP_ID extends LogKey | ||
| case object APP_NAME extends LogKey | ||
| case object APP_STATE extends LogKey | ||
| case object ARCHIVE_NAME extends LogKey | ||
| case object ARGS extends LogKey | ||
| case object ATTRIBUTE_MAP extends LogKey | ||
| case object AUTH_ENABLED extends LogKey | ||
| case object BACKUP_FILE extends LogKey | ||
| case object BARRIER_EPOCH extends LogKey | ||
|
|
@@ -145,6 +151,8 @@ object LogKeys { | |
| case object DATA_FILE extends LogKey | ||
| case object DATA_SOURCE extends LogKey | ||
| case object DATA_SOURCES extends LogKey | ||
| case object DECOMMISSION_INFO extends LogKey | ||
| case object DEFAULT_COMPACTION_INTERVAL extends LogKey | ||
| case object DEFAULT_COMPACT_INTERVAL extends LogKey | ||
| case object DEFAULT_ISOLATION_LEVEL extends LogKey | ||
| case object DEFAULT_NAME extends LogKey | ||
|
|
@@ -246,6 +254,8 @@ object LogKeys { | |
| case object HADOOP_VERSION extends LogKey | ||
| case object HASH_JOIN_KEYS extends LogKey | ||
| case object HASH_MAP_SIZE extends LogKey | ||
| case object HAS_R_PACKAGE extends LogKey | ||
| case object HEADING extends LogKey | ||
| case object HEARTBEAT extends LogKey | ||
| case object HEARTBEAT_INTERVAL extends LogKey | ||
| case object HISTORY_DIR extends LogKey | ||
|
|
@@ -255,10 +265,12 @@ object LogKeys { | |
| case object HIVE_OPERATION_TYPE extends LogKey | ||
| case object HOST extends LogKey | ||
| case object HOST_LOCAL_BLOCKS_SIZE extends LogKey | ||
| case object HOST_NAME extends LogKey | ||
| case object HOST_NAMES extends LogKey | ||
| case object HOST_PORT extends LogKey | ||
| case object HOST_PORT2 extends LogKey | ||
| case object HUGE_METHOD_LIMIT extends LogKey | ||
| case object HYBRID_STORE_DISK_BACKEND extends LogKey | ||
| case object IDENTIFIER extends LogKey | ||
| case object INCOMPATIBLE_TYPES extends LogKey | ||
| case object INDEX extends LogKey | ||
|
|
@@ -268,6 +280,7 @@ object LogKeys { | |
| case object INIT extends LogKey | ||
| case object INITIAL_CAPACITY extends LogKey | ||
| case object INITIAL_HEARTBEAT_INTERVAL extends LogKey | ||
| case object INITIAL_REGISTRATION_RETRIES extends LogKey | ||
| case object INIT_MODE extends LogKey | ||
| case object INPUT extends LogKey | ||
| case object INPUT_SPLIT extends LogKey | ||
|
|
@@ -280,6 +293,7 @@ object LogKeys { | |
| case object JAVA_VERSION extends LogKey | ||
| case object JAVA_VM_NAME extends LogKey | ||
| case object JOB_ID extends LogKey | ||
| case object JOB_TAG extends LogKey | ||
| case object JOIN_CONDITION extends LogKey | ||
| case object JOIN_CONDITION_SUB_EXPR extends LogKey | ||
| case object JOIN_TYPE extends LogKey | ||
|
|
@@ -331,6 +345,7 @@ object LogKeys { | |
| case object MAX_METHOD_CODE_SIZE extends LogKey | ||
| case object MAX_NUM_BINS extends LogKey | ||
| case object MAX_NUM_CHUNKS extends LogKey | ||
| case object MAX_NUM_FILES extends LogKey | ||
| case object MAX_NUM_LOG_POLICY extends LogKey | ||
| case object MAX_NUM_PARTITIONS extends LogKey | ||
| case object MAX_NUM_POSSIBLE_BINS extends LogKey | ||
|
|
@@ -354,8 +369,10 @@ object LogKeys { | |
| case object METRIC_NAME extends LogKey | ||
| case object MINI_BATCH_FRACTION extends LogKey | ||
| case object MIN_COMPACTION_BATCH_ID extends LogKey | ||
| case object MIN_FREQUENT_PATTERN_COUNT extends LogKey | ||
| case object MIN_NUM_FREQUENT_PATTERN extends LogKey | ||
| case object MIN_POINT_PER_CLUSTER extends LogKey | ||
| case object MIN_REGISTER_RATIO extends LogKey | ||
| case object MIN_SHARE extends LogKey | ||
| case object MIN_SIZE extends LogKey | ||
| case object MIN_TIME extends LogKey | ||
|
|
@@ -373,6 +390,7 @@ object LogKeys { | |
| case object NEW_VALUE extends LogKey | ||
| case object NEXT_RENEWAL_TIME extends LogKey | ||
| case object NODES extends LogKey | ||
| case object NODE_IDS extends LogKey | ||
| case object NODE_LOCATION extends LogKey | ||
| case object NON_BUILT_IN_CONNECTORS extends LogKey | ||
| case object NORM extends LogKey | ||
|
|
@@ -422,6 +440,7 @@ object LogKeys { | |
| case object NUM_FILES_FAILED_TO_DELETE extends LogKey | ||
| case object NUM_FILES_REUSED extends LogKey | ||
| case object NUM_FREQUENT_ITEMS extends LogKey | ||
| case object NUM_GRACEFULLY_DECOMMISSIONED extends LogKey | ||
| case object NUM_HOST_LOCAL_BLOCKS extends LogKey | ||
| case object NUM_INDEX_FILE extends LogKey | ||
| case object NUM_INDEX_FILES extends LogKey | ||
|
|
@@ -453,6 +472,7 @@ object LogKeys { | |
| case object NUM_PRUNED extends LogKey | ||
| case object NUM_PUSH_MERGED_LOCAL_BLOCKS extends LogKey | ||
| case object NUM_RECORDS_READ extends LogKey | ||
| case object NUM_RELEASED_LOCKS extends LogKey | ||
| case object NUM_REMAINED extends LogKey | ||
| case object NUM_REMOTE_BLOCKS extends LogKey | ||
| case object NUM_REMOVED_WORKERS extends LogKey | ||
|
|
@@ -514,6 +534,7 @@ object LogKeys { | |
| case object PATHS extends LogKey | ||
| case object PEER extends LogKey | ||
| case object PERCENT extends LogKey | ||
| case object PERCENTILE_HEADER extends LogKey | ||
| case object PIPELINE_STAGE_UID extends LogKey | ||
| case object PLUGIN_NAME extends LogKey | ||
| case object POD_ID extends LogKey | ||
|
|
@@ -557,6 +578,7 @@ object LogKeys { | |
| case object QUERY_RUN_ID extends LogKey | ||
| case object RANGE extends LogKey | ||
| case object RDD_CHECKPOINT_DIR extends LogKey | ||
| case object RDD_CREATION_SITE extends LogKey | ||
| case object RDD_DEBUG_STRING extends LogKey | ||
| case object RDD_DESCRIPTION extends LogKey | ||
| case object RDD_ID extends LogKey | ||
|
|
@@ -571,11 +593,13 @@ object LogKeys { | |
| case object RECOVERY_STATE extends LogKey | ||
| case object REDACTED_STATEMENT extends LogKey | ||
| case object REDUCE_ID extends LogKey | ||
| case object REGEX extends LogKey | ||
| case object REGISTERED_EXECUTOR_FILE extends LogKey | ||
| case object REGISTER_MERGE_RESULTS extends LogKey | ||
| case object RELATION_NAME extends LogKey | ||
| case object RELATION_OUTPUT extends LogKey | ||
| case object RELATIVE_TOLERANCE extends LogKey | ||
| case object RELEASED_LOCKS extends LogKey | ||
| case object REMAINING_PARTITIONS extends LogKey | ||
| case object REMOTE_ADDRESS extends LogKey | ||
| case object REMOTE_BLOCKS_SIZE extends LogKey | ||
|
|
@@ -588,10 +612,13 @@ object LogKeys { | |
| case object RESOURCE_PROFILE_ID extends LogKey | ||
| case object RESOURCE_PROFILE_IDS extends LogKey | ||
| case object RESOURCE_PROFILE_TO_TOTAL_EXECS extends LogKey | ||
| case object RESPONSE extends LogKey | ||
| case object RESPONSE_BODY_SIZE extends LogKey | ||
| case object REST_PROTOCOL_RESPONSE_MESSAGE_TYPE extends LogKey | ||
| case object RESULT extends LogKey | ||
| case object RESULT_SIZE_BYTES extends LogKey | ||
| case object RESULT_SIZE_BYTES_MAX extends LogKey | ||
| case object RETRY_COUNT extends LogKey | ||
| case object RETRY_INTERVAL extends LogKey | ||
| case object RETRY_WAIT_TIME extends LogKey | ||
| case object RIGHT_EXPR extends LogKey | ||
|
|
@@ -651,6 +678,8 @@ object LogKeys { | |
| case object STAGE extends LogKey | ||
| case object STAGES extends LogKey | ||
| case object STAGE_ATTEMPT extends LogKey | ||
| case object STAGE_ATTEMPT_ID extends LogKey | ||
| case object STAGE_ATTEMPT_NUMBER extends LogKey | ||
| case object STAGE_ID extends LogKey | ||
| case object STAGE_NAME extends LogKey | ||
| case object START_INDEX extends LogKey | ||
|
|
@@ -660,6 +689,7 @@ object LogKeys { | |
| case object STATE_STORE_VERSION extends LogKey | ||
| case object STATS extends LogKey | ||
| case object STATUS extends LogKey | ||
| case object STAT_COUNTER extends LogKey | ||
| case object STDERR extends LogKey | ||
| case object STOP_SITE_SHORT_FORM extends LogKey | ||
| case object STORAGE_LEVEL extends LogKey | ||
|
|
@@ -688,11 +718,13 @@ object LogKeys { | |
| case object TARGET_NUM_EXECUTOR extends LogKey | ||
| case object TARGET_NUM_EXECUTOR_DELTA extends LogKey | ||
| case object TARGET_PATH extends LogKey | ||
| case object TASK extends LogKey | ||
| case object TASK_ATTEMPT_ID extends LogKey | ||
| case object TASK_ID extends LogKey | ||
| case object TASK_LOCALITY extends LogKey | ||
| case object TASK_NAME extends LogKey | ||
| case object TASK_REQUIREMENTS extends LogKey | ||
| case object TASK_RESOURCES extends LogKey | ||
| case object TASK_RESOURCE_ASSIGNMENTS extends LogKey | ||
| case object TASK_SET_ID extends LogKey | ||
| case object TASK_SET_MANAGER extends LogKey | ||
|
|
@@ -727,6 +759,8 @@ object LogKeys { | |
| case object TOPIC_PARTITION_OFFSET_RANGE extends LogKey | ||
| case object TOTAL extends LogKey | ||
| case object TOTAL_EFFECTIVE_TIME extends LogKey | ||
| case object TOTAL_RECORDS_READ extends LogKey | ||
|
||
| case object TOTAL_REGISTRATION_RETRIES extends LogKey | ||
| case object TOTAL_SIZE extends LogKey | ||
| case object TOTAL_TIME extends LogKey | ||
| case object TOTAL_TIME_READ extends LogKey | ||
|
|
@@ -749,6 +783,7 @@ object LogKeys { | |
| case object URIS extends LogKey | ||
| case object URL extends LogKey | ||
| case object URL2 extends LogKey | ||
| case object URLS extends LogKey | ||
| case object USER_ID extends LogKey | ||
| case object USER_NAME extends LogKey | ||
| case object UUID extends LogKey | ||
|
|
@@ -764,6 +799,7 @@ object LogKeys { | |
| case object WORKER extends LogKey | ||
| case object WORKER_HOST extends LogKey | ||
| case object WORKER_ID extends LogKey | ||
| case object WORKER_MEMORY extends LogKey | ||
|
||
| case object WORKER_PORT extends LogKey | ||
| case object WORKER_URL extends LogKey | ||
| case object WRITE_AHEAD_LOG_INFO extends LogKey | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.