Skip to content

[SPARK-48551][SQL] Perf improvement for escapePathName #46894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 12 commits into from
Closed

[SPARK-48551][SQL] Perf improvement for escapePathName #46894

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eff6d77
[SPARK-48548][SQL] Perf improvement for escapePathName
yaooqinn Jun 6, 2024
019cfb2
[SPARK-48548][SQL] Perf improvement for escapePathName
yaooqinn Jun 7, 2024
d04b589
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/cata…
yaooqinn Jun 7, 2024
3fac8fc
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/cata…
yaooqinn Jun 7, 2024
e3e783d
tests
yaooqinn Jun 7, 2024
072a957
nit
yaooqinn Jun 7, 2024
e118917
address comments
yaooqinn Jun 7, 2024
bac8b9d
update golden files
yaooqinn Jun 7, 2024
c6a0cf7
corner case
yaooqinn Jun 7, 2024
74dee2b
address comments
yaooqinn Jun 11, 2024
bd38e8b
address comments
yaooqinn Jun 11, 2024
b7c1e0c
address comments
yaooqinn Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
  • Loading branch information
@yaooqinn
yaooqinn committed Jun 11, 2024
commit 74dee2bcc48a3ed61f7ec0f99047f1909c207d6e
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ object ExternalCatalogUtils {
while (firstIndex < length && !needsEscaping(path.charAt(firstIndex))) {
firstIndex += 1
}
if (firstIndex == 0 && !needsEscaping(path.charAt(0))) {
if (firstIndex == length) {
path
} else {
val sb = new java.lang.StringBuilder(length + 16)
Expand Down