Skip to content

Conversation

@panbingkun
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to use R 4.4.0 in windows R GitHub Action job.

Why are the changes needed?

R 4.4.0 is the latest release which is released on 2024-04-24.
https://www.r-project.org/

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label Jun 6, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-48554][INFRA] Use R 4.4.0 in windows R GitHub Action job [SPARK-48554][INFRA] Use R 4.4.0 in windows R GitHub Action Window job Jun 6, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HyukjinKwon
Copy link
Member

I think ... this might break SparkR build (https://github.com/apache/spark/actions/runs/9331838894) assuming from the timeline ..

@HyukjinKwon
Copy link
Member

Let me revert this first, and see if the build passes.

@panbingkun
Copy link
Contributor Author

Let me revert this first, and see if the build passes.

Okay, Let me investigate it.

@panbingkun
Copy link
Contributor Author

@HyukjinKwon
It doesn't seem like the issue was caused by this upgrade,
It also encountered similar issues when the version is 4.3.3
https://github.com/panbingkun/spark/actions/runs/9576846198/job/26404013779
From the log stack, it seems that there is an exception in the character unescape
I suspect what character on Windows is causing it.

Let me continue to address its root cause.

@panbingkun
Copy link
Contributor Author

panbingkun commented Jun 19, 2024

I have reproduced this issue and let me see how to fix it correctly

C:\Users\runneradmin\AppData\Local\Temp\spark-9f4b7e74-ea9e-46fc-bde6-1449cc9f6e8e\userFiles-aaee9fd8-13b2-4cb2-a968-52895086988b\run-all.R
image
\u

@panbingkun
Copy link
Contributor Author

panbingkun commented Jun 21, 2024

@HyukjinKwon
#47021
https://github.com/panbingkun/spark/actions/runs/9611425119/job/26509953539
I have verified windows R (4.3.3) on GA and it has passed. Now I will verify the 4.4.0 version again.
If there are no issues, I think we can bring this upgrade back.


https://github.com/panbingkun/spark/runs/26513013494

R 4.4.0 is ok.

@HyukjinKwon
Copy link
Member

let me revert this back.

@panbingkun
Copy link
Contributor Author

let me revert this back.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants