[SPARK-47777] fix python streaming data source connect test #46906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reaming data source ### What changes were proposed in this pull request? Make python streaming data source pyspark test also runs on spark connect. Refactor the test because foreachbatch runs on spark connect server and do not update local variable. ### Why are the changes needed? Test python streaming data source on spark connect. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Test change. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45950 from chaoqin-li1123/source_spark_connect. Authored-by: Chaoqin Li <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
chaoqin-li1123
force-pushed
the
fix_include
branch
from
723c757 to
94f6248
Compare
Contributor
Author
|
@HyukjinKwon Thanks for helping with debugging this issue! |
chaoqin-li1123
changed the title
allisonwang-db
approved these changes
Jun 14, 2024
HyukjinKwon
approved these changes
Jun 17, 2024
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add back python streaming data source connect test. Previously we remove this test because it fails in pure python spark connect library due to missing py4j.
This is because in python_streaming_source_runner, we import from pyspark.java_gateway instead of pyspark.utils, and pyspark.java_gateway requires py4j
from pyspark.java_gateway import local_connect_and_authThis was introduced in c8c2492 accidentally.
Why are the changes needed?
Add spark connect test for python streaming data source.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test change.
Was this patch authored or co-authored using generative AI tooling?
No.