[SPARK-48572][SQL] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions #46943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
reviewed
Jun 14, 2024
Contributor
There was a problem hiding this comment.
note: I wanted to eventually cover this in #46659, but I'll close that now
Contributor
|
btw, should we add some tests for these changes? |
Contributor
Author
|
Will add them a bit later and will remove WIP when it is done. |
mihailomilosevic2001
changed the title
mihailomilosevic2001
changed the title
Contributor
Author
|
@cloud-fan could you review this? |
cloud-fan
approved these changes
Jun 17, 2024
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix for listed expressions.
Why are the changes needed?
These expressions are found to be faulty when working with collations.
Does this PR introduce any user-facing change?
Yes, it fixes expressions that are not working with collations.
How was this patch tested?
Tests added for expressions to reproduce errors.
Was this patch authored or co-authored using generative AI tooling?
No.