[SPARK-48584][SQL][FOLLOWUP] Improve the unescapePathName. #46957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-48584_followup
branch
from
a5cd0ff to
3b7b4bf
Compare
Contributor
Author
|
ping @yaooqinn @LuciferYang |
yaooqinn
reviewed
Jun 13, 2024
Member
There was a problem hiding this comment.
FYI, for scala 3, do-while is removed
Contributor
There was a problem hiding this comment.
Yes, what @yaooqinn said is correct:
Welcome to Scala 3.3.1 (17.0.11, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.
scala> var x = 10
|
| do {
| println("Value of x: " + x)
| x = x - 1
| } while (x > 0)
-- Error: ----------------------------------------------------------------------
3 |do {
|^^
|end of statement expected but 'do' found
Contributor
Author
There was a problem hiding this comment.
Thank you for the remind. I will revert it.
beliefer
force-pushed
the
SPARK-48584_followup
branch
from
3b7b4bf to
70749c9
Compare
yaooqinn
approved these changes
Jun 13, 2024
Contributor
Author
|
Merged to master. Thank you @yaooqinn @LuciferYang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR follows up #46938 and improve the
unescapePathName.Why are the changes needed?
Improve the
unescapePathNameby cut off slow path.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.