Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Jun 12, 2024

What changes were proposed in this pull request?

SPARK-40876 enhanced the built-in Parquet data source reader to support widening type promotions, we should update the test to reflect this capability.

Why are the changes needed?

Update test to cover new feature.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

build/sbt "sql/testOnly *ParquetReadSchemaSuite"

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Jun 12, 2024
@pan3793
Copy link
Member Author

pan3793 commented Jun 13, 2024

cc @yaooqinn @LuciferYang

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but cc @dongjoon-hyun

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @pan3793

@yaooqinn yaooqinn closed this in 8fdd85f Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants