[SPARK-45685][SQL][FOLLOWUP] Add handling for Stream where LazyList.force is called
#46970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jun 13, 2024
| case d: DataType => d // Avoid unpacking Structs | ||
| case stream: LazyList[_] => stream.map(recursiveTransform).force | ||
| case stream: Stream[_] => stream.map(recursiveTransform).force | ||
| case lazyList: LazyList[_] => lazyList.map(recursiveTransform).force |
Contributor
Author
There was a problem hiding this comment.
cc @JoshRosen Did I understand your suggestion correctly? Thanks ~
Contributor
There was a problem hiding this comment.
@LuciferYang, yes, this is exactly what I had in mind.
JoshRosen
approved these changes
Jun 13, 2024
Contributor
JoshRosen
left a comment
JoshRosen
left a comment
There was a problem hiding this comment.
The code changes here look good to me (and are in line with what I suggested in my comment at #43563 (review) reporting the potential issue). Thanks for also updating the unit tests to ensure test coverage of the new branches.
LGTM pending filling out a PR description.
LuciferYang
changed the title
Stream where LazyList.force is calledStream where LazyList.force is called
Contributor
Author
|
Merged into master for Spark 4.0. Thanks @JoshRosen ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refer to the suggestion of #43563 (review), this pr add handling for
StreamwhereLazyList.forceis called.Why are the changes needed?
Even though
Streamis deprecated in 2.13, it is not removed and thus is is possible that some parts of Spark / Catalyst (or third-party code) might continue to pass aroundStreaminstances. Hence, we should restore the call toStream.forcewhere.forceis called onLazyList, to avoid losing the eager materialization for Streams that happen to flow to these call sites. This is also a guarantee of compatibility.Does this PR introduce any user-facing change?
No
How was this patch tested?
Add some new tests
Was this patch authored or co-authored using generative AI tooling?
No