Skip to content

[SPARK-48056][CONNECT][FOLLOW-UP] Scala Client re-execute plan if a SESSION_NOT_FOUND error is raised and no partial response was received #46971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 6 commits into from
Closed

[SPARK-48056][CONNECT][FOLLOW-UP] Scala Client re-execute plan if a SESSION_NOT_FOUND error is raised and no partial response was received #46971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58891a9
[SPARK-48056][CONNECT][SCALA] Re-execute plan if a SESSION_NOT_FOUND …
Jun 13, 2024
d778f91
Fix indentation
Jun 13, 2024
6473a33
Dummy
Jun 13, 2024
d709920
Dummy
Jun 13, 2024
ad41e3a
Reduce test time
Jun 13, 2024
b47605d
Fix fmt
Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix fmt
  • Loading branch information
Changgyoo Park committed Jun 13, 2024
commit b47605d5d44f49830e16f8332f5624a72e1cd275
5 changes: 3 additions & 2 deletions ...ient/jvm/src/test/scala/org/apache/spark/sql/connect/client/SparkConnectClientSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,8 +537,9 @@ class SparkConnectClientSuite extends ConnectFunSuite with BeforeAndAfterEach {
.connectionString(s"sc://localhost:${server.getPort}")
.enableReattachableExecute()
.build()
service.errorToThrowOnExecute = Some(new StatusRuntimeException(
Status.INTERNAL.withDescription("INVALID_HANDLE.SESSION_NOT_FOUND")))
service.errorToThrowOnExecute = Some(
new StatusRuntimeException(
Status.INTERNAL.withDescription("INVALID_HANDLE.SESSION_NOT_FOUND")))

val plan = buildPlan("select * from range(1)")
val iter = client.execute(plan)
Expand Down
2 changes: 1 addition & 1 deletion ...n/scala/org/apache/spark/sql/connect/client/ExecutePlanResponseReattachableIterator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ class ExecutePlanResponseReattachableIterator(
if Option(StatusProto.fromThrowable(ex))
.exists(ex => {
ex.getMessage.contains("INVALID_HANDLE.OPERATION_NOT_FOUND") ||
ex.getMessage.contains("INVALID_HANDLE.SESSION_NOT_FOUND")
ex.getMessage.contains("INVALID_HANDLE.SESSION_NOT_FOUND")
}) =>
if (lastReturnedResponseId.isDefined) {
throw new IllegalStateException(
Expand Down