[SPARK-48626][CORE] Change the scope of object LogKeys as private in Spark #46983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Jun 14, 2024
Member
pan3793
left a comment
pan3793
left a comment
There was a problem hiding this comment.
Thanks for making this change.
yaooqinn
approved these changes
Jun 14, 2024
LuciferYang
changed the title
Contributor
|
All Test passed. Merged into master. Thanks @gengliangwang @yaooqinn and @pan3793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the scope of object LogKeys as private in Spark.
Why are the changes needed?
LogKeys are internal and developing. Making it private can avoid future confusion or compiling failures.
This is suggested by @pan3793 in #46947 (comment)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT
Was this patch authored or co-authored using generative AI tooling?
No