[SPARK-48630][INFRA] Make merge_spark_pr keep the format of revert PR
#46988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let's probably keep it as |
Contributor
Author
sounds good. For a revert PR, we don't need to format it |
zhengruifeng
changed the title
merge_spark_pr properly format revert PRmerge_spark_pr properly handle revert PR
zhengruifeng
force-pushed
the
fix_merge_spark_pr_for_revert
branch
from
f5617fa to
db30154
Compare
zhengruifeng
changed the title
merge_spark_pr properly handle revert PRmerge_spark_pr properly handle revert PR
allisonwang-db
approved these changes
Jun 17, 2024
Contributor
allisonwang-db
left a comment
allisonwang-db
left a comment
There was a problem hiding this comment.
Shall we also update the PR description?
zhengruifeng
changed the title
merge_spark_pr properly handle revert PRmerge_spark_pr keep the format of revert PR
zhengruifeng
force-pushed
the
fix_merge_spark_pr_for_revert
branch
from
db30154 to
eee0ed5
Compare
HyukjinKwon
approved these changes
Jun 21, 2024
Contributor
Author
|
thanks, merged to master with this modified script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
merge_spark_prkeep the format of revert PRWhy are the changes needed?
existing script format revert PR in this way:
another example:
was modified to
see 82a84ed
Does this PR introduce any user-facing change?
no, infra-only
How was this patch tested?
manually test, let me use this script to merge some PR to check
Was this patch authored or co-authored using generative AI tooling?
No