Skip to content

[SPARK-48634][PYTHON][CONNECT] Avoid statically initialize threadpool at ExecutePlanResponseReattachableIterator #46993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 4 commits into from
Closed

[SPARK-48634][PYTHON][CONNECT] Avoid statically initialize threadpool at ExecutePlanResponseReattachableIterator #46993

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cd391e
Avoid statically initialize threadpool at ExecutePlanResponseReattach…
HyukjinKwon Jun 14, 2024
b1804f2
Update python/pyspark/sql/connect/client/reattach.py
HyukjinKwon Jun 17, 2024
e06e4dc
reformat
HyukjinKwon Jun 17, 2024
7b81621
minor fixup
HyukjinKwon Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update python/pyspark/sql/connect/client/reattach.py 
Co-authored-by: Martin Grund <[email protected]>
  • Loading branch information
@HyukjinKwon @grundprinzip
HyukjinKwon and grundprinzip authored Jun 17, 2024
commit b1804f287921fdd129ccd9e50dfa910b1be210e3
3 changes: 3 additions & 0 deletions python/pyspark/sql/connect/client/reattach.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ class ExecutePlanResponseReattachableIterator(Generator):
@classmethod # type: ignore[misc]
@property
def _release_thread_pool(cls) -> ThreadPool:
# Perform a first check outside the critical path.
if not cls._release_thread_pool_instance is None:
return cls._release_thread_pool_instance
with cls._lock:
if cls._release_thread_pool_instance is None:
cls._release_thread_pool_instance = ThreadPool(
Expand Down