[SPARK-48635][SQL] Assign classes to join type errors and as-of join error #46994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneguow
changed the title
Contributor
Author
allisonwang-db
approved these changes
Jun 17, 2024
Contributor
|
cc @ueshin |
ueshin
approved these changes
Jun 20, 2024
HyukjinKwon
approved these changes
Jun 21, 2024
Member
|
Merged to master. |
Contributor
Author
|
Thank you all. @HyukjinKwon @ueshin @allisonwang-db |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR renames a few error classes related to
join typeandas-of join:Why are the changes needed?
Proper error names and messages improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
Yes, this PR changes user-facing error class and message.
How was this patch tested?
Passed GA.
By running test cases in
JoinTypesTest,DatasetSuiteandDataFrameAsOfJoinSuite.Was this patch authored or co-authored using generative AI tooling?
No.