[SPARK-48574][SQL] Fix support for StructTypes with collations #46997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d54453e.
HyukjinKwon
approved these changes
Jun 17, 2024
yaooqinn
approved these changes
Jun 17, 2024
Contributor
Author
|
@cloud-fan This is ready for merge now. Resolved conflicts of test oredering in CollationSQLExpressionsSuite. |
Contributor
Author
|
@HyukjinKwon could we merge this change in? |
Member
|
Merged to master, thank you @mihailom-db |
Contributor
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix for ExtractValue expression
Why are the changes needed?
This fix is needed in case we change default collation.
Does this PR introduce any user-facing change?
Yes, it fixes a problem.
How was this patch tested?
Added tests in
CollationSQLExpressionsSuite.scalaWas this patch authored or co-authored using generative AI tooling?
No.