Skip to content

[SPARK-47986][CONNECT][FOLLOW-UP] Unable to create a new session when the default session is closed by the server #47008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 16 commits into from
Closed

[SPARK-47986][CONNECT][FOLLOW-UP] Unable to create a new session when the default session is closed by the server #47008

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3f09510
Test added / not working correctly
Jun 17, 2024
20e1e09
Merge remote-tracking branch 'origin/master' into SPARK-47986
Jun 18, 2024
cb589fa
Complete fix
Jun 18, 2024
1df2600
Cleanup
Jun 18, 2024
f844fe5
Fix lint errors
Jun 18, 2024
710cb64
Get rid of unnecessary CAS loop
Jun 18, 2024
1d9d2a3
Revive CAS loop
Jun 18, 2024
468f55b
Finalize
Jun 18, 2024
abc2e43
Merge remote-tracking branch 'origin/master' into SPARK-47986
Jun 19, 2024
be37220
Address review comments
Jun 19, 2024
f04ef3e
Fix, major
Jun 19, 2024
e4e0376
Another fix, major
Jun 19, 2024
4ff5bec
Fix, minor
Jun 19, 2024
5da4711
Simplify implementation and add more comments
Jun 19, 2024
9c24efd
Replace `refresh` with `invalidate` to be on the safe side
Jun 19, 2024
9c98205
Merge remote-tracking branch 'origin/master' into SPARK-47986
Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace refresh with invalidate to be on the safe side
  • Loading branch information
Changgyoo Park committed Jun 19, 2024
commit 9c24efdd8989c2bab441dd2a61004cb65de35787
6 changes: 3 additions & 3 deletions connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,9 +1033,9 @@ object SparkSession extends Logging {
.getOrElse({
var existingSession = sessions.get(builder.configuration)
Copy link
Member

@HyukjinKwon HyukjinKwon Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a lock here for sessions?

Copy link
Author

@ghost ghost Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so as Cache is backed by ConcurrentMap which allows concurrent access to the data. Source: https://guava.dev/releases/17.0/api/docs/com/google/common/cache/CacheBuilder.html.

if (!existingSession.client.isSessionValid) {
// If the cached session has become invalid, e.g., due to a server restart, this creates
// a new one and returns it.
sessions.refresh(builder.configuration)
// If the cached session has become invalid, e.g., due to a server restart, the cache
// entry is invalidated.
sessions.invalidate(builder.configuration)
existingSession = sessions.get(builder.configuration)
}
existingSession
Expand Down