[SPARK-48658][SQL] Encode/Decode functions report coding errors instead of mojibake for unmappable characters #47017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @cloud-fan @dongjoon-hyun @LuciferYang @HyukjinKwon thanks |
cloud-fan
reviewed
Jun 19, 2024
connector/connect/common/src/test/resources/query-tests/explain-results/function_decode.explain
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jun 19, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
Hi @cloud-fan, I have addressed your comments. The expressions are now replaced at runtime by static invoke, and the string representations no longer contain those legacy flags. |
cloud-fan
reviewed
Jun 24, 2024
| test("SPARK-22543: split large if expressions into blocks due to JVM code size limit") { | ||
| var strExpr: Expression = Literal("abc") | ||
| for (_ <- 1 to 150) { | ||
| strExpr = StringDecode(Encode(strExpr, "utf-8"), "utf-8") |
Contributor
There was a problem hiding this comment.
can we use a different expression for testing? The codegen size is greatly decreased after using StaticInvoke in Encode.
cloud-fan
approved these changes
Jun 24, 2024
HyukjinKwon
reviewed
Jun 24, 2024
| "instead of reporting coding errors.") | ||
| .version("4.0.0") | ||
| .booleanConf | ||
| .createWithDefault(false) |
Member
There was a problem hiding this comment.
I wonder if it should be a fallback conf to ANSI.
Member
Author
There was a problem hiding this comment.
The reasons I'd like to make it independent of ANSI are:
- Part of the implication of ANSI is Hive-incompatibility,
- Hive also reports coding errors, so it was a mistake when we ported this from hive
- These functions are not ANSI-defined
- The error behaviors are also not found in ANSI
The reasons mentioned above indicate that this behavior is more of a legacy trait of Spark itself.
Member
Author
|
Merged to master. Thank you @cloud-fan @HyukjinKwon for the help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes encode/decode functions report coding errors instead of mojibake for unmappable characters, take
select encode('渭城朝雨浥轻尘', 'US-ASCII')as an exampleBefore this PR，
After this PR，
Why are the changes needed?
Improve data quality.
Does this PR introduce any user-facing change?
Yes.
When set spark.sql.legacy.codingErrorAction to true, encode/decode functions replace unmappable characters with mojibake instead of reporting coding errors.
How was this patch tested?
new unit tests
Was this patch authored or co-authored using generative AI tooling?
no