[SPARK-48659][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. SET TBLPROPERTIES tests #47018
Conversation
| ifExists = true)) | ||
| } | ||
|
|
||
| // ALTER TABLE table_name SET TBLPROPERTIES ('comment' = new_comment); |
There was a problem hiding this comment.
Only tests related to SET have been moved, and tests related to UNSET will doing in another PR
| } | ||
|
|
||
| // ALTER TABLE table_name SET TBLPROPERTIES ('comment' = new_comment); | ||
| test("alter table: alter table properties") { |
There was a problem hiding this comment.
Ported from sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
| Map("test" -> "test", "comment" -> "new_comment"))) | ||
| } | ||
|
|
||
| test("alter table - property values must be set") { |
There was a problem hiding this comment.
Ported from sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
|
@cloud-fan Can you take a time to help review? Thank you very much. |
|
cc @HyukjinKwon |
|
thanks, merging to master! |
|
Yea let's add AlterNamespaceUnsetPropertiesExec for DS v2 |
Thank you for your review! |
2 participants
What changes were proposed in this pull request?
o.a.s.s.c.p.DDLParserSuiteando.a.s.s.e.c.DDLParserSuitetoAlterTableSetTblPropertiesParserSuite.DDLSuiteandHiveDDLSuitetov1.AlterTableSetTblPropertiesBaseand tov1.AlterTableSetTblPropertiesSuite.ALTER TABLE .. RENAMEtov2.AlterTableSetTblPropertiesSuite.Why are the changes needed?
AlterTableRename*Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.