Skip to content

Conversation

@wayneguow
Copy link
Contributor

@wayneguow wayneguow commented Jun 19, 2024

What changes were proposed in this pull request?

This PR aims to upgrade RoaringBitmap to 1.1.0.

Why are the changes needed?

There are some bug fixes in RoaringBitmap 1.1.0:
Fix RunContainer#contains(BitmapContainer) (RoaringBitmap/RoaringBitmap#721) by @LeeWorrall in RoaringBitmap/RoaringBitmap#722
Fix ArrayContainer#contains(RunContainer) (RoaringBitmap/RoaringBitmap#723) by @LeeWorrall in RoaringBitmap/RoaringBitmap#724

Full release note:
https://github.com/RoaringBitmap/RoaringBitmap/releases/tag/1.1.0

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Jun 19, 2024
@wayneguow
Copy link
Contributor Author

Waiting for the latest version to be released in the maven central repo.

@LuciferYang
Copy link
Contributor

LuciferYang commented Jun 19, 2024

@wayneguow please update the benchmark result of MapStatusesConvertBenchmark

@github-actions github-actions bot added the CORE label Jun 20, 2024
@wayneguow
Copy link
Contributor Author

@wayneguow please update the benchmark result of MapStatusesConvertBenchmark

@LuciferYang Thanks for your guidance, I have added the latest benchmark data.
jdk17: https://github.com/wayneguow/spark/actions/runs/9592491598
jdk21: https://github.com/wayneguow/spark/actions/runs/9592917394

@wayneguow wayneguow marked this pull request as ready for review June 20, 2024 07:45
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(pending tests)

@LuciferYang
Copy link
Contributor

Merged into master for Spark 4.0. Thanks @wayneguow and @yaooqinn

@wayneguow
Copy link
Contributor Author

Thank you all @LuciferYang @yaooqinn .

@wayneguow wayneguow deleted the upgrade_RoaringBitmap branch February 11, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants