Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jun 20, 2024

What changes were proposed in this pull request?

The pr aims to upgrade scalafmt to 3.8.2.

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.
Manually test:

sh dev/scalastyle
-e Scalastyle checks passed.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Jun 20, 2024
@panbingkun panbingkun marked this pull request as ready for review June 20, 2024 23:22
@panbingkun
Copy link
Contributor Author

cc @HyukjinKwon

@HyukjinKwon
Copy link
Member

Can you check there are some code modification, and run this? This script is only effective when there are some changes IIRC.

@panbingkun
Copy link
Contributor Author

panbingkun commented Jun 21, 2024

Can you check there are some code modification, and run this? This script is only effective when there are some changes IIRC.

The verification process is as follows:

  • positive

    (base) ➜  spark-community git:(SPARK-48677) ✗ git diff
    
    image
    (base) ➜  spark-community git:(SPARK-48677) ✗ sh dev/scalastyle
    -e Scalastyle checks passed.
    
  • negative

    (base) ➜  spark-community git:(SPARK-48677) ✗ git diff
    
    image
(base) ➜  spark-community git:(SPARK-48677) ✗ sh dev/scalastyle
-e Scalastyle checks failed at following occurrences:
[error] /Users/panbingkun/Developer/spark/spark-community/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterNamespaceSetPropertiesExec.scala:35:4: Are you sure you want to println? If yes, wrap the code block with
[error]       // scalastyle:off println
[error]       println(...)
[error]       // scalastyle:on println
[error] Total time: 19 s, completed Jun 21, 2024, 8:15:30 AM

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants