-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-48697][SQL] Add collation aware string filters #47059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
reviewed
Jun 24, 2024
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
Outdated
Show resolved
Hide resolved
Contributor
|
I think there is some misunderstanding here. Filter pushdown has a few steps:
I don't get why we need |
f6c6bd7 to
a4458b6
Compare
Contributor
Author
|
@cloud-fan I made some changes per our discussion, let me know what you think |
cloud-fan
reviewed
Jun 28, 2024
cloud-fan
reviewed
Jun 28, 2024
cloud-fan
reviewed
Jun 28, 2024
...ore/src/test/scala/org/apache/spark/sql/collation/CollatedFilterPushDownToParquetSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Jun 28, 2024
cloud-fan
approved these changes
Jul 1, 2024
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding a new classes of filters which are collation aware.
Why are the changes needed?
#46760 Added the logic of predicate widening for collated column references, but this would completely change the filters and if the original expression did not get evaluated by spark later we could end up with wrong results. Also, data sources would never be able to actually support these filters and they would just see them as AlwaysTrue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UTs.
Was this patch authored or co-authored using generative AI tooling?
No.